DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(rnf): really normalize spaces

Browse source 
Fix #10653
This commit is contained in:
Colin Darie 2024-08-01 18:54:50 +02:00
parent 3660e01d76
commit 720a312b00
No known key found for this signature in database
GPG key ID: 4FB865FDBCA4BCC4
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/champs/rnf_champ.rb
View file

@ -2,7 +2,7 @@ class Champs::RNFChamp < Champ
store_accessor :data, :title, :email, :phone, :createdAt, :updatedAt, :dissolvedAt, :address, :status store_accessor :data, :title, :email, :phone, :createdAt, :updatedAt, :dissolvedAt, :address, :status
def rnf_id def rnf_id
external_id&.gsub(/[:space:]/, '') external_id&.gsub(/[[:space:]]/, '')
end end
def value def value

12
spec/models/champs/rnf_champ_spec.rb
View file

@ -7,7 +7,7 @@ describe Champs::RNFChamp, type: :model do
describe 'fetch_external_data' do describe 'fetch_external_data' do
let(:url) { RNFService.new.send(:url) } let(:url) { RNFService.new.send(:url) }
let(:status) { 200 } let(:status) { 200 }
before { stub_request(:get, "#{url}/#{external_id}").to_return(body:, status:) } before { stub_request(:get, "#{url}/075-FDD-00003-01").to_return(body:, status:) }
subject { champ.fetch_external_data } subject { champ.fetch_external_data }
@ -51,20 +51,14 @@ describe Champs::RNFChamp, type: :model do
context 'success (with space)' do context 'success (with space)' do
let(:external_id) { '075-FDD- 00003-01 ' } let(:external_id) { '075-FDD- 00003-01 ' }
it { it {
expect(subject.value!).to include({ expect(subject).to be_success
id: 3,
rnfId: '075-FDD-00003-01'
})
} }
end end
context 'success (with tab)' do context 'success (with tab)' do
let(:external_id) { '075-FDD-0 0003-01 ' } let(:external_id) { '075-FDD-0 0003-01 ' }
it { it {
expect(subject.value!).to include({ expect(subject).to be_success
id: 3,
rnfId: '075-FDD-00003-01'
})
} }
end end