DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(a11y/footer): add "new tab" suffix on title links

Browse source 
Cf #8050
This commit is contained in:
Colin Darie 2022-11-28 15:48:40 +01:00
parent e60fb1f0c1
commit 720995f48f
6 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/application_helper.rb
View file

@ -129,6 +129,10 @@ module ApplicationHelper
{ target: "_blank", rel: "noopener noreferrer" } { target: "_blank", rel: "noopener noreferrer" }
end end
def new_tab_suffix(title)
"#{title} — #{t('utils.new_tab')}"
end
def download_details(attachment) def download_details(attachment)
"#{attachment.filename.extension.upcase} – #{number_to_human_size(attachment.byte_size)}" "#{attachment.filename.extension.upcase} – #{number_to_human_size(attachment.byte_size)}"
end end

12
app/views/root/_footer.html.haml
View file

@ -50,19 +50,19 @@
.fr-footer__content .fr-footer__content
%p.fr-footer__content-desc %p.fr-footer__content-desc
= t('links.footer.description_1') = t('links.footer.description_1')
= link_to t('links.footer.link_1_label'), t('links.footer.link_1_url'), target: '_blank' = link_to(t('links.footer.link_1_label'), t('links.footer.link_1_url'), title: new_tab_suffix(t('links.footer.link_1_label')), target: '_blank') + "."
%p.fr-footer__content-desc %p.fr-footer__content-desc
= link_to t('links.footer.link_2_label'), t("links.footer.code.url"), target: '_blank' = link_to t('links.footer.link_2_label'), t("links.footer.code.url"), title: new_tab_suffix(t('links.footer.link_2_label')), target: '_blank'
= t('links.footer.description_2') = t('links.footer.description_2')
%ul.fr-footer__content-list %ul.fr-footer__content-list
%li.fr-footer__content-item %li.fr-footer__content-item
= link_to t('users.procedure_footer.official_links.legifrance.title'), t('users.procedure_footer.official_links.legifrance.url'), class: 'fr-footer__content-link', target: '_blank' = link_to t('users.procedure_footer.official_links.legifrance.title'), t('users.procedure_footer.official_links.legifrance.url'), title: new_tab_suffix(t('users.procedure_footer.official_links.legifrance.title')), class: 'fr-footer__content-link', target: '_blank'
%li.fr-footer__content-item %li.fr-footer__content-item
= link_to t('users.procedure_footer.official_links.gouvernement.title'), t('users.procedure_footer.official_links.gouvernement.url'), class: 'fr-footer__content-link', target: '_blank' = link_to t('users.procedure_footer.official_links.gouvernement.title'), t('users.procedure_footer.official_links.gouvernement.url'), title: new_tab_suffix(t('users.procedure_footer.official_links.gouvernement.title')), class: 'fr-footer__content-link', target: '_blank'
%li.fr-footer__content-item %li.fr-footer__content-item
= link_to t('users.procedure_footer.official_links.service_public.title'), t('users.procedure_footer.official_links.service_public.url'), class: 'fr-footer__content-link', target: '_blank' = link_to t('users.procedure_footer.official_links.service_public.title'), t('users.procedure_footer.official_links.service_public.url'), title: new_tab_suffix(t('users.procedure_footer.official_links.service_public.title')), class: 'fr-footer__content-link', target: '_blank'
%li.fr-footer__content-item %li.fr-footer__content-item
= link_to t('users.procedure_footer.official_links.data_gouv.title'), t('users.procedure_footer.official_links.data_gouv.url'), class: 'fr-footer__content-link', target: '_blank' = link_to t('users.procedure_footer.official_links.data_gouv.title'), t('users.procedure_footer.official_links.data_gouv.url'), title: new_tab_suffix(t('users.procedure_footer.official_links.data_gouv.title')), class: 'fr-footer__content-link', target: '_blank'
.fr-footer__bottom .fr-footer__bottom
= render partial: 'users/general_footer_row' = render partial: 'users/general_footer_row'

2
app/views/shared/_footer_copy.html.haml
View file

@ -1,4 +1,4 @@
.fr-footer__bottom-copy .fr-footer__bottom-copy
%p %p
Sauf mention contraire, tous les contenus de ce site sont sous Sauf mention contraire, tous les contenus de ce site sont sous
%a{ href: "https://github.com/etalab/licence-ouverte/blob/master/LO.md", target:"_blank", rel: "noopener", title: "licence etalab-2.0 - nouvelle fenêtre" } licence etalab-2.0 %a{ href: "https://github.com/etalab/licence-ouverte/blob/master/LO.md", target:"_blank", rel: "noopener", title: new_tab_suffix("licence etalab-2.0") } licence etalab-2.0

1
config/locales/en.yml
View file

@ -50,6 +50,7 @@ en:
message: Message message: Message
send_mail: Send message send_mail: Send message
procedure: Procedures procedure: Procedures
new_tab: New tab
helpers: helpers:
procedure: procedure:
testing_procedure: testing procedure testing_procedure: testing procedure

1
config/locales/fr.yml
View file

@ -40,6 +40,7 @@ fr:
message: Message message: Message
send_mail: Envoyer le message send_mail: Envoyer le message
procedure: Démarches procedure: Démarches
new_tab: "Nouvel onglet"
helpers: helpers:
procedure: procedure:
testing_procedure: démarche en test testing_procedure: démarche en test

2
config/locales/links.fr.yml
View file

@ -12,7 +12,7 @@ fr:
resources: Ressources resources: Ressources
diagnostic: Diagnostic diagnostic: Diagnostic
description_1: Démarches simplifiées est un service propulsé par description_1: Démarches simplifiées est un service propulsé par
link_1_label: la direction interministérielle du numérique (DINUM). link_1_label: la direction interministérielle du numérique (DINUM)
link_1_url: "https://www.numerique.gouv.fr/dinum/" link_1_url: "https://www.numerique.gouv.fr/dinum/"
link_2_label: Le code source link_2_label: Le code source
description_2: est disponible en licence libre. description_2: est disponible en licence libre.