DGNum/demarches-normaliennes
11
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

FC information: remove funny find_by

Browse source
This commit is contained in:
simon lehericey 2018-01-11 18:26:55 +01:00 committed by Simon Lehericey
parent 8e26a50f16
commit 7024e14d1c
3 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/france_connect/particulier_controller.rb
View file

@ -11,7 +11,8 @@ class FranceConnect::ParticulierController < ApplicationController
user_infos = FranceConnectService.retrieve_user_informations_particulier(params[:code]) user_infos = FranceConnectService.retrieve_user_informations_particulier(params[:code])
if user_infos.present? if user_infos.present?
france_connect_information = FranceConnectInformation.find_by_france_connect_particulier(user_infos) france_connect_information = FranceConnectInformation
.find_by(france_connect_particulier_id: user_infos[:france_connect_particulier_id])
if france_connect_information.nil? if france_connect_information.nil?
france_connect_information = FranceConnectInformation.create( france_connect_information = FranceConnectInformation.create(

4
app/models/france_connect_information.rb
View file

@ -2,8 +2,4 @@ class FranceConnectInformation < ActiveRecord::Base
belongs_to :user belongs_to :user
validates :france_connect_particulier_id, presence: true, allow_blank: false, allow_nil: false validates :france_connect_particulier_id, presence: true, allow_blank: false, allow_nil: false
def self.find_by_france_connect_particulier user_info
FranceConnectInformation.find_by(france_connect_particulier_id: user_info[:france_connect_particulier_id])
end
end end

16
spec/models/france_connect_information_spec.rb
View file

@ -8,20 +8,4 @@ describe FranceConnectInformation, type: :model do
it { is_expected.to allow_value('mon super projet').for(:france_connect_particulier_id) } it { is_expected.to allow_value('mon super projet').for(:france_connect_particulier_id) }
end end
end end
describe '.find_by_france_connect_particulier' do
let(:user_info) { {france_connect_particulier_id: '123456'} }
subject { described_class.find_by_france_connect_particulier user_info }
context 'when france_connect_particulier_id is prensent in database' do
let!(:france_connect_information) { create(:france_connect_information, france_connect_particulier_id: '123456') }
it { is_expected.to eq france_connect_information }
end
context 'when france_connect_particulier_id is prensent in database' do
it { is_expected.to eq nil }
end
end
end end