DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

refactor(groupe instructeur): use logic validation system for routing

Browse source 
rule"
This commit is contained in:
Eric Leroy-Terquem 2023-11-06 17:44:21 +01:00
parent 3e2e5a01f9
commit 6c959d9d4e
1 changed files with 2 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/models/groupe_instructeur.rb
View file

@ -116,23 +116,8 @@ class GroupeInstructeur < ApplicationRecord
private private
def routing_rule_matches_tdc?(rule) def routing_rule_matches_tdc?(rule)
routing_tdc = procedure.active_revision.types_de_champ.find_by(stable_id: rule.left.stable_id) tdcs = procedure.active_revision.types_de_champ_public
rule.errors(tdcs).blank?
options = case routing_tdc.type_champ
when TypeDeChamp.type_champs.fetch(:communes), TypeDeChamp.type_champs.fetch(:departements), TypeDeChamp.type_champs.fetch(:epci)
APIGeoService.departements.map { _1[:code] }
when TypeDeChamp.type_champs.fetch(:regions)
APIGeoService.regions.map { _1[:code] }
when TypeDeChamp.type_champs.fetch(:drop_down_list), TypeDeChamp.type_champs.fetch(:multiple_drop_down_list)
routing_tdc.drop_down_list_enabled_non_empty_options(other: true).map { _1.is_a?(Array) ? _1.last : _1 }
when TypeDeChamp.type_champs.fetch(:checkbox), TypeDeChamp.type_champs.fetch(:yes_no)
[true, false]
when TypeDeChamp.type_champs.fetch(:integer_number)
return rule.right.value.is_a? Integer
when TypeDeChamp.type_champs.fetch(:decimal_number)
return rule.right.value.is_a? Float
end
rule.right.value.in?(options)
end end
serialize :routing_rule, LogicSerializer serialize :routing_rule, LogicSerializer