refactor(service): explicit call to service job to avoid test side effect
This commit is contained in:
parent
0a1ab733b6
commit
6af4fe624a
4 changed files with 10 additions and 25 deletions
|
@ -15,6 +15,8 @@ module Administrateurs
|
|||
@service.administrateur = current_administrateur
|
||||
|
||||
if @service.save
|
||||
@service.enqueue_api_entreprise
|
||||
|
||||
redirect_to admin_services_path(procedure_id: params[:procedure_id]),
|
||||
notice: "#{@service.nom} créé"
|
||||
else
|
||||
|
@ -33,6 +35,10 @@ module Administrateurs
|
|||
@service = service
|
||||
|
||||
if @service.update(service_params)
|
||||
if @service.siret_previously_changed?
|
||||
@service.enqueue_api_entreprise
|
||||
end
|
||||
|
||||
redirect_to admin_services_path(procedure_id: params[:procedure_id]),
|
||||
notice: "#{@service.nom} modifié"
|
||||
else
|
||||
|
|
|
@ -45,8 +45,6 @@ class Service < ApplicationRecord
|
|||
validates :adresse, presence: { message: 'doit être renseignée' }, allow_nil: false
|
||||
validates :administrateur, presence: { message: 'doit être renseigné' }, allow_nil: false
|
||||
|
||||
after_commit :enqueue_api_entreprise, if: -> { siret_previously_changed? }
|
||||
|
||||
def clone_and_assign_to_administrateur(administrateur)
|
||||
service_cloned = self.dup
|
||||
service_cloned.administrateur = administrateur
|
||||
|
@ -67,8 +65,6 @@ class Service < ApplicationRecord
|
|||
[etablissement_lat, etablissement_lng]
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def enqueue_api_entreprise
|
||||
APIEntreprise::ServiceJob.perform_later(self.id)
|
||||
end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue