Merge pull request #8409 from colinux/fix-association-adapter

Fix RNA Association adapter sans date_publication

app/lib/api_entreprise/rna_adapter.rb

@@ -15,10 +15,17 @@ class APIEntreprise::RNAAdapter < APIEntreprise::Adapter
 
   def process_params
     params = data_source[:association]
+
+    Sentry.with_scope do |scope|
+      scope.set_tags(siret: @siret)
+      scope.set_extras(source: params)
+
       params = params&.slice(*attr_to_fetch) if @depreciated
       params[:rna] = data_source.dig(:association, :id)
+
       if params[:rna].present? && valid_params?(params)
         params = params.transform_keys { |k| :"association_#{k}" }.deep_stringify_keys
+
         raise InvalidSchemaError.new(schemer.validate(params).to_a) unless schemer.valid?(params)
 
         params
@@ -26,6 +33,7 @@ class APIEntreprise::RNAAdapter < APIEntreprise::Adapter
         {}
       end
     end
+  end
 
   def schemer
     @schemer ||= JSONSchemer.schema(Rails.root.join('app/schemas/association.json'))

app/schemas/association.json

@@ -29,9 +29,16 @@
       "format": "date"
     },
     "association_date_publication": {
+      "anyOf": [
+        {
           "type": "string",
           "format": "date"
         },
+        {
+          "type": "null"
+        }
+      ]
+    },
     "association_date_dissolution": {
       "anyOf": [
         {
@@ -236,7 +243,6 @@
   "required": [
     "association_titre",
     "association_rna",
-    "association_date_declaration",
-    "association_date_publication"
+    "association_date_declaration"
   ]
 }

spec/lib/api_entreprise/rna_adapter_spec.rb

@@ -30,7 +30,6 @@ describe APIEntreprise::RNAAdapter do
       expect(subject["association_titre"]).to eq('UN SUR QUATRE')
       expect(subject["association_objet"]).to eq("valoriser, transmettre et partager auprès des publics les plus larges possibles, les bienfaits de l'immigration, la richesse de la diversité et la curiosité de l'autre autrement")
       expect(subject["association_date_declaration"]).to eq('2014-01-24')
-      expect(subject["association_date_publication"]).to eq('2014-02-08')
     end
   end