Refactor function create in user dossier controller

spec/controllers/users/dossiers_controller_spec.rb

@@ -12,6 +12,9 @@ describe Users::DossiersController, type: :controller do
   let(:rna_status) { 404 }
   let(:rna_body) { '' }
 
+  let(:exercices_status) { 200 }
+  let(:exercices_body) { File.read('spec/support/files/exercices.json') }
+
   let(:siren) { dossier.siren }
   let(:siret) { dossier.siret }
   let(:bad_siret) { 1 }
@@ -78,7 +81,7 @@ describe Users::DossiersController, type: :controller do
           .to_return(status: 200, body: File.read('spec/support/files/entreprise.json'))
 
       stub_request(:get, "https://api-dev.apientreprise.fr/api/v1/etablissements/exercices/#{siret}?token=#{SIADETOKEN}")
-          .to_return(status: 200, body: File.read('spec/support/files/exercices.json'))
+          .to_return(status: exercices_status, body: exercices_body)
 
       stub_request(:get, "https://api-dev.apientreprise.fr/api/v1/associations/#{siret}?token=#{SIADETOKEN}")
           .to_return(status: rna_status, body: rna_body)
@@ -131,6 +134,13 @@ describe Users::DossiersController, type: :controller do
           expect(Exercice.last.etablissement).to eq(Dossier.last.etablissement)
         end
 
+        context 'when siret have no exercices' do
+          let(:exercices_status) { 404 }
+          let(:exercices_body) { '' }
+
+          it { expect { subject }.not_to change { Exercice.count } }
+        end
+
         it 'links procedure to dossier' do
           subject
           expect(Dossier.last.procedure).to eq(Procedure.last)

spec/lib/siade/exercices_adapter_spec.rb

@@ -10,7 +10,7 @@ describe SIADE::ExercicesAdapter do
   end
 
   it '#to_params class est une Hash ?' do
-    expect(subject).to be_an_instance_of(Hash)
+    expect(subject).to be_an_instance_of(Array)
   end
 
   it 'have 3 exercices' do