dossiers: allow auto upload of attachments

spec/features/users/brouillon_spec.rb

@@ -5,9 +5,6 @@ feature 'The user' do
   let!(:procedure) { create(:procedure, :published, :for_individual, :with_all_champs_mandatory) }
   let(:user_dossier) { user.dossiers.first }
 
-  # TODO: check
-  # the order
-  # there are no extraneous input
   scenario 'fill a dossier', js: true, vcr: { cassette_name: 'api_geo_departements_regions_et_communes' } do
     log_in(user, procedure)
 
@@ -160,6 +157,14 @@ feature 'The user' do
     create(:procedure, :published, :for_individual, types_de_champ: tdcs)
   end
 
+  let(:procedure_with_pjs) do
+    tdcs = [
+      create(:type_de_champ_piece_justificative, mandatory: true, libelle: 'Pièce justificative 1', order_place: 1),
+      create(:type_de_champ_piece_justificative, mandatory: true, libelle: 'Pièce justificative 2', order_place: 2)
+    ]
+    create(:procedure, :published, :for_individual, types_de_champ: tdcs)
+  end
+
   scenario 'adding, replacing and removing attachments', js: true do
     log_in(user, procedure_with_pj)
     fill_individual
@@ -191,6 +196,85 @@ feature 'The user' do
     expect(page).to have_no_text('RIB.pdf')
   end
 
+  context 'when the auto-uploads of attachments is enabled' do
+    before do
+      Flipper.enable_actor(:autoupload_dossier_attachments, user)
+    end
+
+    scenario 'add an attachment', js: true do
+      log_in(user, procedure_with_pjs)
+      fill_individual
+
+      # Add attachments
+      find_field('Pièce justificative 1').attach_file(Rails.root + 'spec/fixtures/files/file.pdf')
+      find_field('Pièce justificative 2').attach_file(Rails.root + 'spec/fixtures/files/RIB.pdf')
+
+      # Expect the files to be uploaded immediately
+      expect(page).to have_text('analyse antivirus en cours', count: 2)
+      expect(page).to have_text('file.pdf')
+      expect(page).to have_text('RIB.pdf')
+
+      # Expect the submit buttons to be enabled
+      expect(page).to have_button('Enregistrer le brouillon', disabled: false)
+      expect(page).to have_button('Déposer le dossier', disabled: false)
+
+      # Reload the current page
+      visit current_path
+
+      # Expect the files to have been saved on the dossier
+      expect(page).to have_text('file.pdf')
+      expect(page).to have_text('RIB.pdf')
+    end
+
+    # TODO: once we're running on Rails 6, re-enable the validator on PieceJustificativeChamp,
+    # and unmark this spec as pending.
+    #
+    # See piece_justificative_champ.rb
+    # See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926
+    scenario 'add an invalid attachment', js: true, pending: true do
+      log_in(user, procedure_with_pjs)
+      fill_individual
+
+      # Test invalid file type
+      attach_file('Pièce justificative 1', Rails.root + 'spec/fixtures/files/invalid_file_format.json')
+      expect(page).to have_text('La pièce justificative n’est pas d’un type accepté')
+      expect(page).to have_no_button('Ré-essayer', visible: true)
+
+      # Replace the file by another with a valid type
+      attach_file('Pièce justificative 1', Rails.root + 'spec/fixtures/files/piece_justificative_0.pdf')
+      expect(page).to have_no_text('La pièce justificative n’est pas d’un type accepté')
+      expect(page).to have_text('analyse antivirus en cours')
+      expect(page).to have_text('piece_justificative_0.pdf')
+    end
+
+    scenario 'retry on transcient upload error', js: true do
+      log_in(user, procedure_with_pjs)
+      fill_individual
+
+      # Test auto-upload failure
+      logout(:user) # Make the subsequent auto-upload request fail
+      attach_file('Pièce justificative 1', Rails.root + 'spec/fixtures/files/file.pdf')
+      expect(page).to have_text('Une erreur s’est produite pendant l’envoi du fichier')
+      expect(page).to have_button('Ré-essayer', visible: true)
+      expect(page).to have_button('Enregistrer le brouillon', disabled: false)
+      expect(page).to have_button('Déposer le dossier', disabled: false)
+
+      # Test that retrying after a failure works
+      login_as(user, scope: :user) # Make the auto-upload request work again
+      click_on('Ré-essayer', visible: true)
+      expect(page).to have_text('analyse antivirus en cours')
+      expect(page).to have_text('file.pdf')
+      expect(page).to have_button('Enregistrer le brouillon', disabled: false)
+      expect(page).to have_button('Déposer le dossier', disabled: false)
+
+      # Reload the current page
+      visit current_path
+
+      # Expect the file to have been saved on the dossier
+      expect(page).to have_text('file.pdf')
+    end
+  end
+
   context 'when the draft autosave is enabled' do
     before do
       Flipper.enable_actor(:autosave_dossier_draft, user)