Merge pull request #1971 from betagouv/fix_1952_improve_dubious_procedure

Fix 1952 improve dubious procedure

app/jobs/find_dubious_procedures_job.rb

@@ -2,8 +2,9 @@ class FindDubiousProceduresJob < ApplicationJob
   queue_as :cron
 
   FORBIDDEN_KEYWORDS = [
-    'IBAN', 'NIR', 'NIRPP', 'race', 'religion',
+    'NIR', 'NIRPP', 'race', 'religion',
-    'carte bancaire', 'carte bleue', 'sécurité sociale'
+    'carte bancaire', 'carte bleue', 'sécurité sociale', 'nationalité',
+    'agdref', 'handicap', 'syndicat', 'politique'
   ]
 
   def perform(*args)

app/views/administration_mailer/dubious_procedures.html.haml

@@ -3,9 +3,16 @@
 - if @procedures_and_type_de_champs.any?
   %ul
     - @procedures_and_type_de_champs.each do |procedure, type_de_champs|
-      %li
+      %li{ style: 'margin-bottom: 8px;' }
         = link_to "Nº #{procedure.id},", manager_procedure_url(procedure)
          #{procedure.libelle} :
         %b= type_de_champs.map(&:libelle).join(', ')
+        %br
+        État : #{procedure.aasm_state}
+        %br
+        Nombre de dossier : #{procedure.dossiers.count}
+        %br
+          Admin :
+          = link_to "#{procedure.administrateur.email}", "mailto:#{procedure.administrateur.email}"
 - else
   Il n'y a aucune procédure douteuse aujourd'hui

spec/factories/procedure.rb

@@ -119,6 +119,12 @@ FactoryBot.define do
       end
     end
 
+    trait :whitelisted do
+      after(:build) do |procedure, _evaluator|
+        procedure.update(whitelisted_at: DateTime.now)
+      end
+    end
+
     trait :with_notice do
       after(:create) do |procedure, _evaluator|
         procedure.notice.attach(

spec/jobs/find_dubious_procedures_job_spec.rb

@@ -35,13 +35,19 @@ RSpec.describe FindDubiousProceduresJob, type: :job do
       end
 
       context 'and a whitelisted procedure' do
-        let(:procedure) { create(:procedure, whitelisted_at: DateTime.now) }
+        let(:procedure) { create(:procedure, :whitelisted) }
 
         it { expect(AdministrationMailer).to have_received(:dubious_procedures).with([]) }
       end
 
       context 'and a archived procedure' do
-        let(:procedure) { create(:procedure, archived_at: DateTime.now) }
+        let(:procedure) { create(:procedure, :archived) }
+
+        it { expect(AdministrationMailer).to have_received(:dubious_procedures).with([]) }
+      end
+
+      context 'and a hidden procedure' do
+        let(:procedure) { create(:procedure, :hidden) }
 
         it { expect(AdministrationMailer).to have_received(:dubious_procedures).with([]) }
       end