DossierControllerSpec: refactor by remove sign_in test logic

As this test belongs to ProcedureControllerSpec

spec/controllers/new_gestionnaire/dossiers_controller_spec.rb

@@ -5,9 +5,9 @@ describe NewGestionnaire::DossiersController, type: :controller do
   let(:procedure) { create(:procedure, :published, gestionnaires: [gestionnaire]) }
   let(:dossier) { create(:dossier, :replied, procedure: procedure) }
 
-  describe '#attestation' do
+  before { sign_in(gestionnaire) }
-    before { sign_in(gestionnaire) }
 
+  describe '#attestation' do
     context 'when a dossier has an attestation' do
       let(:fake_pdf) { double(read: 'pdf content') }
       let!(:dossier) { create(:dossier, :replied, attestation: Attestation.new, procedure: procedure) }
@@ -28,86 +28,60 @@ describe NewGestionnaire::DossiersController, type: :controller do
     end
   end
 
-  context "when gestionnaire is signed in" do
+  describe '#follow' do
-    before { sign_in(gestionnaire) }
+    before do
-
+      expect_any_instance_of(Dossier).to receive(:next_step!).with('gestionnaire', 'follow')
-    describe '#follow' do
+      patch :follow, params: { procedure_id: procedure.id, dossier_id: dossier.id }
-      before do
-        expect_any_instance_of(Dossier).to receive(:next_step!).with('gestionnaire', 'follow')
-        patch :follow, params: { procedure_id: procedure.id, dossier_id: dossier.id }
-      end
-
-      it { expect(gestionnaire.followed_dossiers).to match([dossier]) }
-      it { expect(flash.notice).to eq('Dossier suivi') }
-      it { expect(response).to redirect_to(procedures_url) }
     end
 
-    describe '#unfollow' do
+    it { expect(gestionnaire.followed_dossiers).to match([dossier]) }
-      before do
+    it { expect(flash.notice).to eq('Dossier suivi') }
-        gestionnaire.followed_dossiers << dossier
+    it { expect(response).to redirect_to(procedures_url) }
-        patch :unfollow, params: { procedure_id: procedure.id, dossier_id: dossier.id }
+  end
-        gestionnaire.reload
-      end
 
-      it { expect(gestionnaire.followed_dossiers).to match([]) }
+  describe '#unfollow' do
-      it { expect(flash.notice).to eq("Vous ne suivez plus le dossier nº #{dossier.id}") }
+    before do
-      it { expect(response).to redirect_to(procedures_url) }
+      gestionnaire.followed_dossiers << dossier
+      patch :unfollow, params: { procedure_id: procedure.id, dossier_id: dossier.id }
+      gestionnaire.reload
     end
 
-    describe '#archive' do
+    it { expect(gestionnaire.followed_dossiers).to match([]) }
-      before do
+    it { expect(flash.notice).to eq("Vous ne suivez plus le dossier nº #{dossier.id}") }
-        patch :archive, params: { procedure_id: procedure.id, dossier_id: dossier.id }
+    it { expect(response).to redirect_to(procedures_url) }
-        dossier.reload
+  end
-      end
 
-      it { expect(dossier.archived).to be true }
+  describe '#archive' do
-      it { expect(response).to redirect_to(procedures_url) }
+    before do
+      patch :archive, params: { procedure_id: procedure.id, dossier_id: dossier.id }
+      dossier.reload
     end
 
-    describe '#unarchive' do
+    it { expect(dossier.archived).to be true }
-      before do
+    it { expect(response).to redirect_to(procedures_url) }
-        dossier.update_attributes(archived: true)
+  end
-        patch :unarchive, params: { procedure_id: procedure.id, dossier_id: dossier.id }
-        dossier.reload
-      end
 
-      it { expect(dossier.archived).to be false }
+  describe '#unarchive' do
-      it { expect(response).to redirect_to(procedures_url) }
+    before do
+      dossier.update_attributes(archived: true)
+      patch :unarchive, params: { procedure_id: procedure.id, dossier_id: dossier.id }
+      dossier.reload
     end
+
+    it { expect(dossier.archived).to be false }
+    it { expect(response).to redirect_to(procedures_url) }
   end
 
   describe "#show" do
-    let(:procedure) { create(:procedure, :published, gestionnaires: [gestionnaire]) }
+    before { get :show, params: { procedure_id: procedure.id, dossier_id: dossier.id } }
-    let(:dossier){ create(:dossier, :replied, procedure: procedure) }
 
-    subject { get :show, params: { procedure_id: procedure.id, dossier_id: dossier.id } }
+    it { expect(response).to have_http_status(:success) }
-
-    context "when gestionnaire is not logged in" do
-      before { subject }
-      it { expect(response).to redirect_to(new_user_session_path) }
-    end
-
-    context "when gestionnaire is logged in" do
-      before { sign_in(gestionnaire) }
-
-      it do
-        subject
-        expect(response).to have_http_status(:success)
-      end
-
-      context "when gestionnaire is not affected on procedure" do
-        let(:dossier){ create(:dossier, :replied) }
-        it { expect{ subject }.to raise_error(ActiveRecord::RecordNotFound) }
-      end
-    end
   end
 
   describe "#create_commentaire" do
     let(:saved_commentaire) { dossier.commentaires.first }
 
     before do
-      sign_in(gestionnaire)
-
       post :create_commentaire, params: {
         procedure_id: procedure.id,
         dossier_id: dossier.id,