DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code

Browse source 
Tech : nettoyage du code conditionnel et routage
This commit is contained in:
Eric Leroy-Terquem 2024-01-29 13:43:52 +00:00 • committed by GitHub
commit 6203b1fd05
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 11 additions and 102 deletions
Download patch file Download diff file Expand all files Collapse all files

11
spec/controllers/instructeurs/dossiers_controller_spec.rb
View file

@ -1275,10 +1275,11 @@ describe Instructeurs::DossiersController, type: :controller do
end
describe '#personnes_impliquees' do
let!(:gi_1) { procedure.groupe_instructeurs.first }
let!(:gi_2) { GroupeInstructeur.create(label: 'deuxième groupe', procedure: procedure) }
let!(:dossier) { create(:dossier, :en_construction, :with_individual, procedure: procedure, groupe_instructeur: gi_1) }
let!(:new_instructeur) { create(:instructeur) }
let(:routed_procedure) { create(:procedure, :routee, :published, :for_individual) }
let(:gi_1) { routed_procedure.groupe_instructeurs.first }
let(:gi_2) { routed_procedure.groupe_instructeurs.last }
let(:dossier) { create(:dossier, :en_construction, :with_individual, procedure: routed_procedure, groupe_instructeur: gi_1) }
let(:new_instructeur) { create(:instructeur) }
before do
gi_1.instructeurs << new_instructeur
@ -1288,7 +1289,7 @@ describe Instructeurs::DossiersController, type: :controller do
get :personnes_impliquees,
params: {
procedure_id: procedure.id,
procedure_id: routed_procedure.id,
dossier_id: dossier.id
}
end

4
spec/models/routing_engine_spec.rb
View file

@ -122,7 +122,7 @@ describe RoutingEngine, type: :model do
context 'with a matching rule' do
before do
gi_2.update(routing_rule: ds_eq(champ_value(communes_tdc.stable_id), constant('92')))
gi_2.update(routing_rule: ds_in_departement(champ_value(communes_tdc.stable_id), constant('92')))
dossier.champs.first.update(code_postal: '92500', external_id: '92063')
end
@ -141,7 +141,7 @@ describe RoutingEngine, type: :model do
context 'with a matching rule' do
before do
gi_2.update(routing_rule: ds_eq(champ_value(epci_tdc.stable_id), constant('42')))
gi_2.update(routing_rule: ds_in_departement(champ_value(epci_tdc.stable_id), constant('42')))
dossier.champs.first.update_columns(
external_id: 244200895,
value: 'CC du Pilat Rhodanien',