DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Attestation: fix missing_attachment

Browse source
This commit is contained in:
Simon Lehericey 2017-06-16 14:10:08 +02:00
parent 58221c8e8a
commit 5c70d38a23
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/controllers/backoffice/dossiers_controller.rb
View file

@ -114,8 +114,6 @@ class Backoffice::DossiersController < Backoffice::DossiersListController
dossier = @facade.dossier dossier = @facade.dossier
attestation_pdf = nil
case params[:process_action] case params[:process_action]
when "refuse" when "refuse"
next_step = "refuse" next_step = "refuse"
@ -129,12 +127,15 @@ class Backoffice::DossiersController < Backoffice::DossiersListController
next_step = "close" next_step = "close"
notice = "Dossier traité avec succès." notice = "Dossier traité avec succès."
template = dossier.procedure.closed_mail_template template = dossier.procedure.closed_mail_template
if check_attestation_emailable(dossier)
attestation_pdf = dossier.attestation.pdf.read
end
end end
dossier.next_step! 'gestionnaire', next_step, motivation dossier.next_step! 'gestionnaire', next_step, motivation
attestation_pdf = nil
if check_attestation_emailable(dossier)
attestation_pdf = dossier.attestation.pdf.read
end
flash.notice = notice flash.notice = notice
NotificationMailer.send_notification(dossier, template, attestation_pdf).deliver_now! NotificationMailer.send_notification(dossier, template, attestation_pdf).deliver_now!

7
spec/controllers/backoffice/dossiers_controller_spec.rb
View file

@ -336,8 +336,11 @@ describe Backoffice::DossiersController, type: :controller do
let(:emailable) { false } let(:emailable) { false }
before do before do
fake_attestation = double(pdf: double(read: 'pdf', size: 2.megabytes), emailable?: emailable) attestation = Attestation.new
allow_any_instance_of(Dossier).to receive(:attestation).and_return(fake_attestation) allow(attestation).to receive(:pdf).and_return(double(read: 'pdf', size: 2.megabytes))
allow(attestation).to receive(:emailable?).and_return(emailable)
allow_any_instance_of(Dossier).to receive(:build_attestation).and_return(attestation)
end end
context 'emailable' do context 'emailable' do