DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(procedure-url-check): don't fail when other attribute have an error

Browse source
This commit is contained in:
Colin Darie 2024-01-29 15:42:35 +01:00
parent 77ca3dd28a
commit 533ce8d7ba
2 changed files with 99 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

38
app/jobs/procedure_external_url_check_job.rb
View file

@ -4,30 +4,28 @@ class ProcedureExternalURLCheckJob < ApplicationJob
if procedure.lien_notice.present?
error = procedure.errors.find { _1.attribute == :lien_notice }
if error.present?
procedure.update!(lien_notice_error: error.message)
else
response = Typhoeus.get(procedure.lien_notice, followlocation: true)
if response.success?
procedure.update!(lien_notice_error: nil)
else
procedure.update!(lien_notice_error: "#{response.code} #{response.return_message}")
end
end
procedure.lien_notice_error = check_for_error(error, procedure.lien_notice)
procedure.save!(validate: false) # others errors may prevent save if validate
end
if procedure.lien_dpo.present? && !procedure.lien_dpo_email?
error = procedure.errors.find { _1.attribute == :lien_dpo }
if error.present?
procedure.update!(lien_dpo_error: error.message)
else
response = Typhoeus.get(procedure.lien_dpo, followlocation: true)
if response.success?
procedure.update!(lien_dpo_error: nil)
else
procedure.update!(lien_dpo_error: "#{response.code} #{response.return_message}")
end
end
procedure.lien_dpo_error = check_for_error(error, procedure.lien_dpo)
procedure.save!(validate: false)
end
end
private
def check_for_error(error, url)
return error.message if error.present?
response = Typhoeus.get(url, followlocation: true)
return if response.success?
"#{response.code} #{response.return_message}"
end
end