refactor(type_de_champ): type_de_champ should not expose revision or procedure
This commit is contained in:
parent
df0dbc1321
commit
5182af820a
20 changed files with 63 additions and 55 deletions
|
@ -4,6 +4,7 @@ class Procedure::RevisionChangesComponent < ApplicationComponent
|
|||
def initialize(new_revision:, previous_revision:)
|
||||
@previous_revision = previous_revision
|
||||
@new_revision = new_revision
|
||||
@procedure = new_revision.procedure
|
||||
|
||||
@tdc_changes = previous_revision.compare_types_de_champ(new_revision)
|
||||
@public_move_changes, @private_move_changes = @tdc_changes.filter { _1.op == :move }.partition { !_1.private? }
|
||||
|
@ -14,6 +15,10 @@ class Procedure::RevisionChangesComponent < ApplicationComponent
|
|||
|
||||
private
|
||||
|
||||
def used_by_routing_rules?(type_de_champ)
|
||||
@procedure.used_by_routing_rules?(type_de_champ)
|
||||
end
|
||||
|
||||
def total_dossiers
|
||||
@total_dossiers ||= @previous_revision.dossiers
|
||||
.visible_by_administration
|
||||
|
|
|
@ -77,7 +77,7 @@
|
|||
- if !total_dossiers.zero? && !change.can_rebase?
|
||||
.fr-alert.fr-alert--warning.fr-mt-1v
|
||||
%p= t('.breaking_change', count: total_dossiers)
|
||||
- if (removed.present? || added.present? ) && change.type_de_champ.used_by_routing_rules?
|
||||
- if (removed.present? || added.present? ) && used_by_routing_rules?(change.type_de_champ)
|
||||
.fr-alert.fr-alert--warning.fr-mt-1v
|
||||
= t(".#{prefix}.update_drop_down_options_alert", label: change.label)
|
||||
- when :drop_down_other
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue