batch it

app/lib/active_storage/downloadable_file.rb

@@ -1,7 +1,6 @@
 class ActiveStorage::DownloadableFile
   def self.create_list_from_dossiers(dossiers, for_expert = false)
-    dossiers
-      .map { |d| pj_and_path(d.id, PiecesJustificativesService.generate_dossier_export(d)) } +
+    PiecesJustificativesService.generate_dossier_export(dossiers) +
       PiecesJustificativesService.liste_documents(dossiers, for_expert)
   end
 

app/services/pieces_justificatives_service.rb

@@ -107,7 +107,10 @@ class PiecesJustificativesService
     end
   end
 
-  def self.generate_dossier_export(dossier)
+  def self.generate_dossier_export(dossiers)
+    pdfs = []
+
+    dossiers.find_each do |dossier|
       pdf = ApplicationController
         .render(template: 'dossiers/show', formats: [:pdf],
                 assigns: {
@@ -115,13 +118,18 @@ class PiecesJustificativesService
                   dossier: dossier
                 })
 
-    FakeAttachment.new(
+      a = FakeAttachment.new(
         file: StringIO.new(pdf),
         filename: "export-#{dossier.id}.pdf",
         name: 'pdf_export_for_instructeur',
         id: dossier.id,
         created_at: dossier.updated_at
       )
+
+      pdfs << ActiveStorage::DownloadableFile.pj_and_path(dossier.id, a)
+    end
+
+    pdfs
   end
 
   private

spec/services/pieces_justificatives_service_spec.rb

@@ -160,7 +160,7 @@ describe PiecesJustificativesService do
   describe '.generate_dossier_export' do
     let(:dossier) { create(:dossier) }
 
-    subject { PiecesJustificativesService.generate_dossier_export(dossier) }
+    subject { PiecesJustificativesService.generate_dossier_export(Dossier.where(id: dossier.id)) }
 
     it "doesn't update dossier" do
       expect { subject }.not_to change { dossier.updated_at }