DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

[#10919] When data in geo_area is invalid do not crash when .label is called

Browse source
This commit is contained in:
Mathieu Magnin 2024-10-15 14:37:32 +02:00
parent 1cd4c7a885
commit 49c9f274e4
No known key found for this signature in database
GPG key ID: 8DCAFC82D7BA654E
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/geo_area.rb
View file

@ -65,7 +65,7 @@ class GeoArea < ApplicationRecord
def label def label
case source case source
when GeoArea.sources.fetch(:cadastre) when GeoArea.sources.fetch(:cadastre)
I18n.t("cadastre", scope: 'geo_area.label', numero: numero, prefixe: prefixe, section: section, surface: surface.round, commune: commune) I18n.t("cadastre", scope: 'geo_area.label', numero: numero, prefixe: prefixe, section: section, surface: surface&.round, commune: commune)
when GeoArea.sources.fetch(:selection_utilisateur) when GeoArea.sources.fetch(:selection_utilisateur)
if polygon? if polygon?
if area > 0 if area > 0

10
spec/models/geo_area_spec.rb
View file

@ -143,6 +143,16 @@ RSpec.describe GeoArea, type: :model do
it "should return the label" do it "should return the label" do
expect(geo_area.label).to eq("Parcelle n° 42 - Feuille 000 A11 - 123 m² – commune 75127") expect(geo_area.label).to eq("Parcelle n° 42 - Feuille 000 A11 - 123 m² – commune 75127")
end end
context "when area is nil" do
let(:geo_area) { build(:geo_area, :selection_utilisateur, :cadastre, properties: { "description" => "48°51'45.81\"N 2°17'15,33\"E" }, geometry: { "type" => "Point", "coordinates" => [7.754444, 48.610556] }, champ: nil) }
before { allow(geo_area).to receive(:area).and_return(nil) }
it "should not crash" do
expect(geo_area.label).to eq("Parcelle n° - Feuille - m² – commune ")
end
end
end end
end end
end end