DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2849 from betagouv/fix_stats_again

Browse source 
StatsController: avoid division by nil
This commit is contained in:
LeSim 2018-10-16 22:38:49 +02:00 committed by GitHub
commit 4680f90a40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/controllers/stats_controller.rb
View file

@ -298,13 +298,19 @@ class StatsController < ApplicationController
# Compute the mean time for this procedure # Compute the mean time for this procedure
procedure_processing_times = dossiers_grouped_by_procedure.map do |procedure_id, procedure_dossiers| procedure_processing_times = dossiers_grouped_by_procedure.map do |procedure_id, procedure_dossiers|
procedure_fields_count = procedure_id_type_de_champs_count[procedure_id]
if (procedure_fields_count == 0 || procedure_fields_count.nil?)
next
end
procedure_dossiers_processing_time = procedure_dossiers.map { |_, processing_time, _| processing_time } procedure_dossiers_processing_time = procedure_dossiers.map { |_, processing_time, _| processing_time }
procedure_mean = mean(procedure_dossiers_processing_time) procedure_mean = mean(procedure_dossiers_processing_time)
# We normalize the data for 24 fields # We normalize the data for 24 fields
procedure_fields_count = procedure_id_type_de_champs_count[procedure_id]
procedure_mean * (MEAN_NUMBER_OF_CHAMPS_IN_A_FORM / procedure_fields_count) procedure_mean * (MEAN_NUMBER_OF_CHAMPS_IN_A_FORM / procedure_fields_count)
end end
.compact
# Compute the average mean time for all the procedures of this month # Compute the average mean time for all the procedures of this month
month_average = mean(procedure_processing_times) month_average = mean(procedure_processing_times)