DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

piece_justificative_service: fix for missing order_place

Browse source 
In production some pieces justificatives don't have an order place.

In this case, insert the champs after the ones that have an order place.
This commit is contained in:
Pierre de La Morinerie 2019-05-28 17:20:07 +02:00
parent c7f2113972
commit 44c410d40d
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
spec/services/pieces_justificatives_service_spec.rb
View file

@ -112,11 +112,25 @@ describe PiecesJustificativesService do
create(
:procedure,
types_de_piece_justificative: tpjs,
types_de_champ: [build(:type_de_champ, order_place: 0)]
types_de_champ: [build(:type_de_champ, order_place: 0), build(:type_de_champ, order_place: 1)]
)
end
it 'generates a sequence of incrementing order_places that continues where the last type de champ left off' do
expect(subject.pluck(:order_place)).to contain_exactly(2, 3)
end
end
context 'with pre-existing champs without an order place' do
let(:procedure) do
create(
:procedure,
types_de_piece_justificative: tpjs,
types_de_champ: [build(:type_de_champ, order_place: 0), build(:type_de_champ, order_place: nil)]
)
end
it 'ignores champs without an order place' do
expect(subject.pluck(:order_place)).to contain_exactly(1, 2)
end
end