DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(6.2.1): home, for each text link with a link title (title attribute), is the content of this attribute relevant?

Browse source 
fix(9.2.1): add nav to footer as it is a navigation area

fix(8.9.1): sign_in, do not use %hr within %p which implicitely close the %p leading to an empty %p after that

fix(9.2.1): sign in, missing %nav element
This commit is contained in:
Martin 2022-05-30 16:50:45 +02:00 • committed by mfo
parent 7cea474231
commit 422990f664
8 changed files with 153 additions and 144 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/views/layouts/commencer/_no_procedure.html.haml
View file

@ -8,6 +8,7 @@
%br %br
= t('.line3') = t('.line3')
%hr %hr
%p
%span.small-simple= t('.are_you_new', app_name: APPLICATION_NAME.gsub("-","‑")).html_safe %span.small-simple= t('.are_you_new', app_name: APPLICATION_NAME.gsub("-","‑")).html_safe
%br %br
%br %br

5
app/views/root/_footer.html.haml
View file

@ -1,7 +1,7 @@
%footer.landing-footer{ role: 'contentinfo' } %footer.landing-footer{ role: 'contentinfo' }
.container .container
%nav{ 'aria-label': t('links.footer.nav_aria', application_name: APPLICATION_NAME) }
%ul.footer-columns %ul.footer-columns
%li.footer-column %li.footer-column
%ul.footer-logos %ul.footer-logos
%li.footer-text %li.footer-text
@ -9,7 +9,7 @@
= link_to t("links.provider.provided_by"), t("links.provider.url"), title: t("links.provider.title") = link_to t("links.provider.provided_by"), t("links.provider.url"), title: t("links.provider.title")
%br %br
%li %li
= link_to t("links.provider.url"), title: t("links.provider.name"), 'aria-label': t("links.provider.name") do = link_to t("links.provider.url"), title: t("links.provider.title"), 'aria-label': t("links.provider.name") do
%span.footer-logo{ role: 'img', 'aria-label': t("links.provider.logo.alt") } %span.footer-logo{ role: 'img', 'aria-label': t("links.provider.logo.alt") }
= image_tag t("links.provider.logo.src"), alt: t("links.provider.logo.alt"), width: t("links.provider.logo.width"), height: t("links.provider.logo.height"), loading: 'lazy' = image_tag t("links.provider.logo.src"), alt: t("links.provider.logo.alt"), width: t("links.provider.logo.width"), height: t("links.provider.logo.height"), loading: 'lazy'
= link_to t("links.footer.betagouv.url"), title: t("links.footer.betagouv.title"), 'aria-label': t("links.footer.betagouv.label") do = link_to t("links.footer.betagouv.url"), title: t("links.footer.betagouv.title"), 'aria-label': t("links.footer.betagouv.label") do
@ -48,3 +48,4 @@
= link_to t("links.footer.status_page.label"), t("links.footer.status_page.url"), title: t("links.footer.status_page.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer" = link_to t("links.footer.status_page.label"), t("links.footer.status_page.url"), title: t("links.footer.status_page.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer"
%li.footer-link %li.footer-link
= link_to t("links.footer.security.label"), t("links.footer.security.url"), title: t("links.footer.security.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer" = link_to t("links.footer.security.label"), t("links.footer.security.url"), title: t("links.footer.security.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer"
}

4
app/views/users/_general_footer_row.html.haml
View file

@ -1,4 +1,6 @@
%ul.footer-row.footer-bottom-line.footer-site-links
%nav{ 'aria-label': t('links.footer.nav_aria', application_name: APPLICATION_NAME) }
%ul.footer-row.footer-bottom-line.footer-site-links
%li.footer-link-accessibilite> %li.footer-link-accessibilite>
= link_to t("links.footer.accessibilite.label"), t("links.footer.accessibilite.url"), title: t("links.footer.accessibilite.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer" = link_to t("links.footer.accessibilite.label"), t("links.footer.accessibilite.url"), title: t("links.footer.accessibilite.title"), class: "footer-link", target: "_blank", rel: "noopener noreferrer"
%li.footer-link-cgu> %li.footer-link-cgu>

1
app/views/users/_procedure_footer.html.haml
View file

@ -2,6 +2,7 @@
.container .container
- service = procedure.service - service = procedure.service
- if service.present? - if service.present?
%nav{ 'aria-label': t('users.procedure_footer.aria_label', procedure_name: dossier.present? ? dossier.procedure.libelle : 'la procédure en ligne') }
.footer-row.footer-columns .footer-row.footer-columns
.footer-column .footer-column
%p.footer-header= I18n.t('users.procedure_footer.managed_by.header') %p.footer-header= I18n.t('users.procedure_footer.managed_by.header')

29
config/locales/links.en.yml
View file

@ -11,9 +11,10 @@ en:
title: "Direction Interministérielle au Numérique" title: "Direction Interministérielle au Numérique"
url: "https://numerique.gouv.fr" url: "https://numerique.gouv.fr"
footer: footer:
nav_aria: "More about %{application_name}"
accessibilite: accessibilite:
label: "Accessibility: partially compliant" label: "Accessibility: partially compliant"
title: "Accessibility: partially compliant" title: "Accessibility declaration"
url: "https://doc.demarches-simplifiees.fr/declaration-daccessibilite" url: "https://doc.demarches-simplifiees.fr/declaration-daccessibilite"
aide: aide:
label: "Help" label: "Help"
@ -29,7 +30,7 @@ en:
url: "https://beta.gouv.fr" url: "https://beta.gouv.fr"
code: code:
label: "Source code" label: "Source code"
title: "Source code" title: "Our Source code is open source"
url: "https://github.com/betagouv/demarches-simplifiees.fr" url: "https://github.com/betagouv/demarches-simplifiees.fr"
cgu: cgu:
label: "ToS" label: "ToS"
@ -37,17 +38,17 @@ en:
url: "https://doc.demarches-simplifiees.fr/cgu" url: "https://doc.demarches-simplifiees.fr/cgu"
contact: contact:
label: "Contact" label: "Contact"
title: "Contact" title: "Contact us"
contact_technique: contact_technique:
label: "Technical contact" label: "Technical contact"
title: "Technical contact" title: "Technical contact for bug report or security feedback"
doc: doc:
label: "Documentation" label: "Documentation"
title: "Documentation" title: "Our Documentation"
url: "https://doc.demarches-simplifiees.fr" url: "https://doc.demarches-simplifiees.fr"
doc_nouveautes: doc_nouveautes:
label: "News" label: "News"
title: "News" title: "Our latest News"
url: "https://doc.demarches-simplifiees.fr/nouveautes" url: "https://doc.demarches-simplifiees.fr/nouveautes"
faq: faq:
label: "FAQ" label: "FAQ"
@ -59,33 +60,33 @@ en:
url: "https:///faq.demarches-simplifiees.fr/collection/1-administrateur-creation-dun-formulaire" url: "https:///faq.demarches-simplifiees.fr/collection/1-administrateur-creation-dun-formulaire"
mentions_legales: mentions_legales:
label: "Legal notices" label: "Legal notices"
title: "Legal notices" title: "Legal notices regarding our platform"
url: "https://doc.demarches-simplifiees.fr/mentions-legales" url: "https://doc.demarches-simplifiees.fr/mentions-legales"
newsletter: newsletter:
label: "Newsletter" label: "Newsletter"
title: "Notre newsletter" title: "Our newsletter"
url: "https://my.sendinblue.com/users/subscribe/js_id/3s2q1/id/1" url: "https://my.sendinblue.com/users/subscribe/js_id/3s2q1/id/1"
releases: releases:
label: "Releases" label: "Releases"
title: "Releases" title: "Our last updates"
url: "https://github.com/betagouv/demarches-simplifiees.fr/releases" url: "https://github.com/betagouv/demarches-simplifiees.fr/releases"
security: security:
label: "Security" label: "Security"
title: "Security" title: "Security policy"
url: "https://github.com/betagouv/demarches-simplifiees.fr/blob/main/SECURITY.md" url: "https://github.com/betagouv/demarches-simplifiees.fr/blob/main/SECURITY.md"
stats: stats:
label: "Statistics" label: "Statistics"
title: "Statistics" title: "Statistics about demarches-simplifiees"
status_page: status_page:
label: "Disponibility" label: "Disponibility"
title: "Disponibility" title: "Disponibility and availability"
url: "https://status.demarches-simplifiees.fr" url: "https://status.demarches-simplifiees.fr"
suivi: suivi:
label: "Audience tracking and privacy" label: "Audience tracking and privacy"
title: "Audience tracking and privacy" title: "Tracking and privacy of demarches-simplifiees"
webinaire: webinaire:
label: "Online workshop registration" label: "Online workshop registration"
title: "Online workshop registration" title: "Registration for our online workshop"
url: "https://app.livestorm.co/demarches-simplifiees" url: "https://app.livestorm.co/demarches-simplifiees"
solidarite_numerique: solidarite_numerique:
label: "Do you need assistance with your digital file?" label: "Do you need assistance with your digital file?"

31
config/locales/links.fr.yml
View file

@ -11,9 +11,10 @@ fr:
title: "Direction Interministérielle au Numérique" title: "Direction Interministérielle au Numérique"
url: "https://numerique.gouv.fr" url: "https://numerique.gouv.fr"
footer: footer:
nav_aria: "En savoir plus sur %{application_name}"
accessibilite: accessibilite:
label: "Accessibilité : partiellement conforme" label: "Accessibilité : partiellement conforme"
title: "Accessibilité : partiellement conforme" title: "Consulter notre déclaration d'accessibilité"
url: "https://doc.demarches-simplifiees.fr/declaration-daccessibilite" url: "https://doc.demarches-simplifiees.fr/declaration-daccessibilite"
aide: aide:
label: "Aide" label: "Aide"
@ -21,7 +22,7 @@ fr:
url: "https://faq.demarches-simplifiees.fr" url: "https://faq.demarches-simplifiees.fr"
api_doc: api_doc:
label: "Documentation de l'API" label: "Documentation de l'API"
title: "Documentation de l'API" title: "Documentation graphql de l'API"
url: "https://doc.demarches-simplifiees.fr/pour-aller-plus-loin/graphql" url: "https://doc.demarches-simplifiees.fr/pour-aller-plus-loin/graphql"
betagouv: betagouv:
label: "Beta.gouv.fr" label: "Beta.gouv.fr"
@ -33,21 +34,21 @@ fr:
url: "https://doc.demarches-simplifiees.fr/cgu" url: "https://doc.demarches-simplifiees.fr/cgu"
code: code:
label: "Code source" label: "Code source"
title: "Code source" title: "Le code ouvert de demarches-simplifiees"
url: "https://github.com/betagouv/demarches-simplifiees.fr" url: "https://github.com/betagouv/demarches-simplifiees.fr"
contact: contact:
label: "Contact" label: "Contact"
title: "Contact" title: "Nous contacter"
contact_technique: contact_technique:
label: "Contact technique" label: "Contact technique"
title: "Contact technique" title: "Contacter notre équipe technique"
doc: doc:
label: "Documentation" label: "Documentation"
title: "Documentation" title: "Documentation utilisateur"
url: "https://doc.demarches-simplifiees.fr" url: "https://doc.demarches-simplifiees.fr"
doc_nouveautes: doc_nouveautes:
label: "Nouveautés" label: "Nouveautés"
title: "Nouveautés" title: "Les dernière nouveautés"
url: "https://doc.demarches-simplifiees.fr/nouveautes" url: "https://doc.demarches-simplifiees.fr/nouveautes"
faq: faq:
label: "FAQ" label: "FAQ"
@ -59,30 +60,30 @@ fr:
url: "https:///faq.demarches-simplifiees.fr/collection/1-administrateur-creation-dun-formulaire" url: "https:///faq.demarches-simplifiees.fr/collection/1-administrateur-creation-dun-formulaire"
mentions_legales: mentions_legales:
label: "Mentions légales" label: "Mentions légales"
title: "Mentions légales" title: "Consulter nos Mentions légales"
url: "https://doc.demarches-simplifiees.fr/mentions-legales" url: "https://doc.demarches-simplifiees.fr/mentions-legales"
newsletter: newsletter:
label: "Newsletter" label: "Infolettres"
title: "Notre newsletter" title: "S'abonner a notre infolettre"
url: "https://my.sendinblue.com/users/subscribe/js_id/3s2q1/id/1" url: "https://my.sendinblue.com/users/subscribe/js_id/3s2q1/id/1"
releases: releases:
label: "Nouveautés" label: "Nouveautés"
title: "Nos nouveautés" title: "Les dernière mises à jour de la plateforme"
url: "https://github.com/betagouv/demarches-simplifiees.fr/releases" url: "https://github.com/betagouv/demarches-simplifiees.fr/releases"
security: security:
label: "Sécurité" label: "Sécurité"
title: "Sécurité" title: "Vous avez identifié une faille, comment nous en informer"
url: "https://github.com/betagouv/demarches-simplifiees.fr/blob/main/SECURITY.md" url: "https://github.com/betagouv/demarches-simplifiees.fr/blob/main/SECURITY.md"
stats: stats:
label: "Statistiques" label: "Statistiques"
title: "Statistiques" title: "Statistiques d'usage"
status_page: status_page:
label: "Disponibilité" label: "Disponibilité"
title: "Disponibilité" title: "Disponibilité du site demarches-simplifiees"
url: "https://status.demarches-simplifiees.fr" url: "https://status.demarches-simplifiees.fr"
suivi: suivi:
label: "Suivi d'audience et vie privée" label: "Suivi d'audience et vie privée"
title: "Suivi d'audience et vie privée" title: "Consulter notre politique de respect de la vie privée"
webinaire: webinaire:
label: "Inscription ateliers en ligne" label: "Inscription ateliers en ligne"
title: "Inscription ateliers en ligne" title: "Inscription ateliers en ligne"

1
config/locales/views/users/procedure_footer/en.yml
View file

@ -1,6 +1,7 @@
en: en:
users: users:
procedure_footer: procedure_footer:
aria_label: "Know more about %{procedure_name}"
managed_by: managed_by:
header: 'This procedure is managed by :' header: 'This procedure is managed by :'
contact: contact:

1
config/locales/views/users/procedure_footer/fr.yml
View file

@ -1,6 +1,7 @@
fr: fr:
users: users:
procedure_footer: procedure_footer:
aria_label: "En savoir plus sur %{procedure_name}"
managed_by: managed_by:
header: 'Cette démarche est gérée par :' header: 'Cette démarche est gérée par :'
contact: contact: