DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #10014 from mfo/US/better-expert-exports

Browse source 
ETQ expert: je retrouve mes avis confidentiel dans les exports. ETQ instructeur, je retrouve les fichiers joint a une demande d'avis expert
This commit is contained in:
Colin Darie 2024-02-21 11:25:58 +00:00 • committed by GitHub
commit 41a27fbad2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 44 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
spec/services/pieces_justificatives_service_spec.rb
View file

@ -224,26 +224,36 @@ describe PiecesJustificativesService do
}
avis.piece_justificative_file.attach(to_be_attached)
avis.introduction_file.attach(avis.piece_justificative_file.blob)
end
context 'given an administrateur' do
let(:user_profile) { build(:administrateur) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).not_to be_empty
expect(subject.size).to eq(2)
end
end
context 'given an instructeur' do
let(:user_profile) { create(:instructeur) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).not_to be_empty
expect(subject.size).to eq(2)
end
end
context 'given an expert' do
let(:user_profile) { create(:expert) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).to be_empty
expect(subject.size).to eq(0)
end
end
context 'when the expert has given the avis' do
let(:experts_procedure) { create(:experts_procedure, expert: user_profile, procedure:) }
let(:avis) { create(:avis, experts_procedure:, dossier: dossier, confidentiel: true) }
let(:user_profile) { create(:expert) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject.size).to eq(2)
end
end
end
@ -251,7 +261,7 @@ describe PiecesJustificativesService do
context 'with avis.piece_justificative being public' do
let(:procedure) { create(:procedure) }
let(:dossier) { create(:dossier, procedure: procedure) }
let(:avis) { create(:avis, dossier: dossier) }
let(:avis) { create(:avis, dossier: dossier, confidentiel: false) }
before do
to_be_attached = {
io: StringIO.new("toto"),
@ -261,26 +271,27 @@ describe PiecesJustificativesService do
}
avis.piece_justificative_file.attach(to_be_attached)
avis.introduction_file.attach(avis.piece_justificative_file.blob)
end
context 'given an administrateur' do
let(:user_profile) { build(:administrateur) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).not_to be_empty
expect(subject.size).to eq(2)
end
end
context 'given an instructeur' do
let(:user_profile) { create(:instructeur) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).not_to be_empty
expect(subject.size).to eq(2)
end
end
context 'given an expert' do
let(:user_profile) { create(:expert) }
it "doesn't return confidentiel avis.piece_justificative_file" do
expect(subject).not_to be_empty
expect(subject.size).to eq(2)
end
end
end