build and render secured URL to invite admin

For clarity and a better understanding, use a dedicated controller to
build and render the confirmation URL to share in order to add a new
administrateur.

app/controllers/manager/confirmation_urls_controller.rb

@@ -0,0 +1,46 @@
+module Manager
+  class ConfirmationUrlsController < Manager::ApplicationController
+    before_action :ensure_administrateur_exists
+    before_action :ensure_not_already_added
+
+    def new
+      @url = confirm_add_administrateur_manager_procedure_url(
+        procedure.id,
+        q: encrypt({ email: params[:email], inviter_id: current_super_admin.id })
+      )
+    end
+
+    private
+
+    def ensure_administrateur_exists
+      redirect("Cet administrateur n'existe pas. Veuillez réessayer.") unless administrateur
+    end
+
+    def ensure_not_already_added
+      redirect("Cet administrateur a déjà été ajouté à cette démarche.") if already_added?
+    end
+
+    def redirect(alert)
+      flash[:alert] = alert
+      redirect_to manager_procedure_path(procedure)
+    end
+
+    def already_added?
+      AdministrateursProcedure.exists?(procedure: procedure, administrateur: administrateur)
+    end
+
+    def administrateur
+      @administrateur ||= Administrateur.by_email(params[:email])
+    end
+
+    def procedure
+      @procedure ||= Procedure.with_discarded.find(params[:procedure_id])
+    end
+
+    def encrypt(parameters)
+      key = Rails.application.key_generator.generate_key(ENV["SECRET_KEY_BASE"])
+      verifier = ActiveSupport::MessageVerifier.new(key)
+      Base64.urlsafe_encode64(verifier.generate(parameters))
+    end
+  end
+end

app/controllers/manager/procedures_controller.rb

@@ -65,10 +65,7 @@ module Manager
     end
 
     def add_administrateur_with_confirmation
-      confirmation_url = confirm_add_administrateur_manager_procedure_url(id: procedure.id, email: current_super_admin.email)
+      redirect_to new_manager_procedure_confirmation_url_path(procedure, email: params[:email])
-
-      flash[:notice] = "Veuillez partager ce lien : #{confirmation_url} avec un autre super admin pour que l'operation soit effectuée"
-      redirect_to manager_procedure_path(procedure)
     end
 
     def confirm_add_administrateur

app/views/manager/application/_navigation.html.erb

@@ -12,7 +12,7 @@ as defined by the routes in the `admin/` namespace
 
   <hr />
 
-  <% Administrate::Namespace.new(namespace).resources.each do |resource| %>
+  <% Administrate::Namespace.new(namespace).resources.select { |resource| resource.to_s != "confirmation_urls" }.each do |resource| %>
 
     <%= link_to(
       display_resource_name(resource),

app/views/manager/confirmation_urls/new.html.erb

@@ -0,0 +1,22 @@
+<% content_for(:title) { "Ajout d'un administrateur" } %>
+
+<header class="main-content__header" role="banner">
+  <h1 class="main-content__page-title">
+    <%= content_for(:title) %>
+  </h1>
+</header>
+
+<section class="main-content__body">
+  <p>
+    Veuillez partager ce lien avec un autre super admin pour que l'opération soit effectuée.
+  </p>
+  <dl>
+    <dt class="attribute-label">
+      Lien
+    </dt>
+    
+    <dd class="attribute-data">
+      <%= @url %>
+    </dd>
+  </dl>
+</section>

config/routes.rb

@@ -21,6 +21,7 @@ Rails.application.routes.draw do
       get 'confirm_add_administrateur', on: :member
       post 'change_piece_justificative_template', on: :member
       get 'export_mail_brouillons', on: :member
+      resources :confirmation_urls, only: :new
     end
 
     resources :archives, only: [:index, :show]

spec/controllers/manager/confirmation_urls_controller_spec.rb

@@ -0,0 +1,73 @@
+describe Manager::ConfirmationUrlsController, type: :controller do
+  let(:inviter_super_admin) { create(:super_admin) }
+  let(:inviter_administrateur) { create(:administrateur, email: inviter_super_admin.email) }
+
+  let(:invited_super_admin) { create(:super_admin) }
+  let(:invited_administrateur) { create(:administrateur, email: invited_super_admin.email) }
+
+  let(:procedure) { create(:procedure, administrateurs: [inviter_administrateur]) }
+
+  before { sign_in inviter_super_admin }
+
+  describe "#add_administrateur_with_confirmation" do
+    render_views
+
+    let(:params) do
+      {
+        procedure_id: procedure.id,
+        email: invited_administrateur.email
+      }
+    end
+
+    before { get :new, params: params }
+
+    it { expect(response).to render_template(:new) }
+
+    it { expect(response.body).to match(/Veuillez partager ce lien/) }
+
+    it "shows the confirmation url with encrypted parameters" do
+      expect(response.body).to include(
+        confirm_add_administrateur_manager_procedure_url(
+          procedure,
+          q: encrypt({ email: invited_administrateur.email, inviter_id: inviter_super_admin.id })
+        )
+      )
+    end
+
+    describe 'edge cases' do
+      context 'when the administrateur does not exist' do
+        let(:params) do
+          {
+            procedure_id: procedure.id,
+            email: "wrong@email.com"
+          }
+        end
+
+        it { expect(flash[:alert]).to match(/Cet administrateur n'existe pas/) }
+
+        it { expect(response).to redirect_to(manager_procedure_path(procedure)) }
+      end
+
+      context 'when the administrateur has already been added to the procedure' do
+        let(:params) do
+          {
+            procedure_id: procedure.id,
+            email: inviter_super_admin.email
+          }
+        end
+
+        it { expect(flash[:alert]).to match(/Cet administrateur a déjà été ajouté/) }
+
+        it { expect(response).to redirect_to(manager_procedure_path(procedure)) }
+      end
+    end
+  end
+
+  private
+
+  def encrypt(parameters)
+    key = Rails.application.key_generator.generate_key(ENV["SECRET_KEY_BASE"])
+    verifier = ActiveSupport::MessageVerifier.new(key)
+    Base64.urlsafe_encode64(verifier.generate(parameters))
+  end
+end