DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

tech(style): prefix columns builders by their table, easier to understand

Browse source
This commit is contained in:
mfo 2024-10-28 17:16:48 +01:00 • committed by simon lehericey
parent fc45e537cf
commit 3bed049a29
No known key found for this signature in database
GPG key ID: CDE670D827C7B3C5
1 changed files with 20 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
app/models/concerns/columns_concern.rb
View file

@ -25,21 +25,16 @@ module ColumnsConcern
columns.concat(standard_columns) columns.concat(standard_columns)
columns.concat(individual_columns) if for_individual columns.concat(individual_columns) if for_individual
columns.concat(moral_columns) if !for_individual columns.concat(moral_columns) if !for_individual
columns.concat(chorus_columns) columns.concat(procedure_chorus_columns)
columns.concat(types_de_champ_columns) columns.concat(types_de_champ_columns)
end end
end end
def chorus_columns
['domaine_fonctionnel', 'referentiel_prog', 'centre_de_cout']
.map { |column| Column.new(procedure_id: id, table: 'procedure', column:, displayable: false, filterable: false) }
end
def all_usager_columns_for_export def all_usager_columns_for_export
columns = [dossier_id_column, email_for_display_column, france_connected_column] columns = [dossier_id_column, user_email_for_display_column, user_france_connected_column]
columns.concat(individual_columns) if for_individual columns.concat(individual_columns) if for_individual
columns.concat(moral_columns) if !for_individual columns.concat(moral_columns) if !for_individual
columns.concat(chorus_columns) if chorusable? && chorus_configuration.complete? columns.concat(procedure_chorus_columns) if chorusable? && chorus_configuration.complete?
columns.flatten.compact columns.flatten.compact
end end
@ -59,20 +54,25 @@ module ColumnsConcern
[states, dossier_archived_column, dossier_dates_columns, dossier_motivation_column, sva_svr_columns(for_export: true), routing, instructeurs].flatten.compact [states, dossier_archived_column, dossier_dates_columns, dossier_motivation_column, sva_svr_columns(for_export: true), routing, instructeurs].flatten.compact
end end
def dossier_id_column ####
Column.new(procedure_id: id, table: 'self', column: 'id', type: :number)
end
def dossier_state_column def dossier_archived_column = Column.new(procedure_id: id, table: 'self', column: 'archived', type: :text, displayable: false, filterable: false);
Column.new(procedure_id: id, table: 'self', column: 'state', label: I18n.t('activerecord.attributes.procedure_presentation.fields.self.state'), type: :enum, scope: 'instructeurs.dossiers.filterable_state', displayable: false)
end
def email_for_display_column = Column.new(procedure_id: id, table: 'self', column: 'user_email_for_display', filterable: false, displayable: false) def dossier_motivation_column = Column.new(procedure_id: id, table: 'self', column: 'motivation', type: :text, displayable: false, filterable: false);
def france_connected_column = Column.new(procedure_id: id, table: 'self', column: 'user_from_france_connect?', filterable: false, displayable: false) def dossier_id_column = Column.new(procedure_id: id, table: 'self', column: 'id', type: :number)
def notifications_column def dossier_state_column = Column.new(procedure_id: id, table: 'self', column: 'state', label: I18n.t('activerecord.attributes.procedure_presentation.fields.self.state'), type: :enum, scope: 'instructeurs.dossiers.filterable_state', displayable: false)
Column.new(procedure_id: id, table: 'notifications', column: 'notifications', label: "notifications", filterable: false)
def notifications_column = Column.new(procedure_id: id, table: 'notifications', column: 'notifications', label: "notifications", filterable: false)
def user_email_for_display_column = Column.new(procedure_id: id, table: 'self', column: 'user_email_for_display', filterable: false, displayable: false)
def user_france_connected_column = Column.new(procedure_id: id, table: 'self', column: 'user_from_france_connect?', filterable: false, displayable: false)
def procedure_chorus_columns
['domaine_fonctionnel', 'referentiel_prog', 'centre_de_cout']
.map { |column| Column.new(procedure_id: id, table: 'procedure', column:, displayable: false, filterable: false) }
end end
def dossier_columns def dossier_columns
@ -113,10 +113,6 @@ module ColumnsConcern
def default_displayed_columns = [email_column] def default_displayed_columns = [email_column]
def dossier_archived_column = Column.new(procedure_id: id, table: 'self', column: 'archived', type: :text, displayable: false, filterable: false);
def dossier_motivation_column = Column.new(procedure_id: id, table: 'self', column: 'motivation', type: :text, displayable: false, filterable: false);
private private
def email_column def email_column
@ -126,12 +122,12 @@ module ColumnsConcern
def standard_columns def standard_columns
[ [
email_column, email_column,
email_for_display_column, user_email_for_display_column,
Column.new(procedure_id: id, table: 'followers_instructeurs', column: 'email'), Column.new(procedure_id: id, table: 'followers_instructeurs', column: 'email'),
Column.new(procedure_id: id, table: 'groupe_instructeur', column: 'id', type: :enum), Column.new(procedure_id: id, table: 'groupe_instructeur', column: 'id', type: :enum),
Column.new(procedure_id: id, table: 'avis', column: 'question_answer', filterable: false), Column.new(procedure_id: id, table: 'avis', column: 'question_answer', filterable: false),
Column.new(procedure_id: id, table: 'user', column: 'id', filterable: false, displayable: false), Column.new(procedure_id: id, table: 'user', column: 'id', filterable: false, displayable: false),
france_connected_column user_france_connected_column
] ]
end end