DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1955 from tchak/fix-commencer

Browse source 
Fix crash with inexistent paths
This commit is contained in:
Paul Chavard 2018-05-23 15:52:12 +02:00 committed by GitHub
commit 3bb3882ce7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/users/dossiers_controller.rb
View file

@ -43,7 +43,7 @@ class Users::DossiersController < UsersController
def commencer_test
procedure_path = ProcedurePath.find_by(path: params[:procedure_path])
procedure = procedure_path.test_procedure
procedure = procedure_path&.test_procedure
if procedure.present?
redirect_to new_users_dossier_path(procedure_id: procedure.id)
@ -55,7 +55,7 @@ class Users::DossiersController < UsersController
def commencer
procedure_path = ProcedurePath.find_by(path: params[:procedure_path])
procedure = procedure_path.procedure
procedure = procedure_path&.procedure
if procedure.present?
if procedure.archivee?

9
spec/controllers/users/dossiers_controller_spec.rb
View file

@ -152,7 +152,8 @@ describe Users::DossiersController, type: :controller do
end
describe 'GET #commencer' do
subject { get :commencer, params: { procedure_path: procedure.path } }
subject { get :commencer, params: { procedure_path: path } }
let(:path) { procedure.path }
it { expect(subject.status).to eq 302 }
it { expect(subject).to redirect_to new_users_dossier_path(procedure_id: procedure.id) }
@ -172,6 +173,12 @@ describe Users::DossiersController, type: :controller do
it { expect(subject).to redirect_to(root_path) }
end
context 'when procedure path dose not exist' do
let(:path) { 'hello' }
it { expect(subject).to redirect_to(root_path) }
end
end
describe 'POST #siret_informations' do