DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

switch from id to class

Browse source
This commit is contained in:
DanteZ5 2022-09-21 11:06:19 +02:00 • committed by LeSim
parent a22851cc35
commit 3826121751
3 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/assets/stylesheets/buttons.scss
View file

@ -317,7 +317,6 @@
color: $blue-france-500; color: $blue-france-500;
} }
#account-btn::before, .account-btn::before {
#account-btn_copy::before { content: none !important;
content: none;
} }

2
app/views/layouts/_account_dropdown.haml
View file

@ -1,6 +1,6 @@
%nav.fr-translate.fr-nav{ role: "navigation", "aria-label"=> t('menu_aria_label', scope: [:layouts]) } %nav.fr-translate.fr-nav{ role: "navigation", "aria-label"=> t('menu_aria_label', scope: [:layouts]) }
.fr-nav__item .fr-nav__item
%button#account-btn.fr-translate__btn.fr-btn{ "aria-controls" => "account", "aria-expanded" => "false", :title => t('my_account', scope: [:layouts]) } %button.account-btn.fr-translate__btn.fr-btn{ "aria-controls" => "account", "aria-expanded" => "false", :title => t('my_account', scope: [:layouts]) }
= image_tag "icons/account-circle.svg", alt: t('my_account', scope: [:layouts]), width: 20, height: 20, loading: 'lazy' = image_tag "icons/account-circle.svg", alt: t('my_account', scope: [:layouts]), width: 20, height: 20, loading: 'lazy'
   
= " #{current_email}" = " #{current_email}"

6
spec/views/layouts/_header_spec.rb
View file

@ -20,7 +20,7 @@ describe 'layouts/_header.html.haml', type: :view do
let(:profile) { nil } let(:profile) { nil }
it { is_expected.to have_css(".fr-header__logo") } it { is_expected.to have_css(".fr-header__logo") }
it { is_expected.to_not have_css("button#account-btn") } it { is_expected.to_not have_css(".account-btn") }
it 'displays the Help link' do it 'displays the Help link' do
expect(subject).to have_link('Aide', href: FAQ_URL) expect(subject).to have_link('Aide', href: FAQ_URL)
@ -45,7 +45,7 @@ describe 'layouts/_header.html.haml', type: :view do
it { is_expected.to have_css(".fr-header__logo") } it { is_expected.to have_css(".fr-header__logo") }
it { is_expected.to have_link("Dossiers", href: dossiers_path) } it { is_expected.to have_link("Dossiers", href: dossiers_path) }
it { is_expected.to have_selector(:button, user.email, id: "account-btn") } it { is_expected.to have_selector(:button, user.email, class: "account-btn") }
it 'displays the Help button' do it 'displays the Help button' do
expect(subject).to have_link("Aide", href: FAQ_URL) expect(subject).to have_link("Aide", href: FAQ_URL)
@ -59,7 +59,7 @@ describe 'layouts/_header.html.haml', type: :view do
let(:current_instructeur) { instructeur } let(:current_instructeur) { instructeur }
it { is_expected.to have_css(".fr-header__logo") } it { is_expected.to have_css(".fr-header__logo") }
it { is_expected.to have_selector(:button, user.email, id: "account-btn") } it { is_expected.to have_selector(:button, user.email, class: "account-btn") }
it 'displays the Help dropdown menu' do it 'displays the Help dropdown menu' do
expect(subject).to have_css(".help-dropdown") expect(subject).to have_css(".help-dropdown")