DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

use join table instead of arrays

Browse source
This commit is contained in:
Paul Chavard 2022-12-22 22:23:47 +01:00 • committed by Lisa Durand
parent 7679ba26b2
commit 378f3c5fb0
10 changed files with 100 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spec/models/batch_operation_spec.rb
View file

@ -2,14 +2,12 @@ describe BatchOperation, type: :model do
describe 'association' do
it { is_expected.to have_many(:dossiers) }
it { is_expected.to belong_to(:instructeur) }
it { is_expected.to have_and_belong_to_many(:groupe_instructeurs) }
it { is_expected.to have_many(:dossier_operations) }
end
describe 'attributes' do
subject { BatchOperation.new }
it { expect(subject.payload).to eq({}) }
it { expect(subject.failed_dossier_ids).to eq([]) }
it { expect(subject.success_dossier_ids).to eq([]) }
it { expect(subject.run_at).to eq(nil) }
it { expect(subject.finished_at).to eq(nil) }
it { expect(subject.operation).to eq(nil) }
@ -56,17 +54,20 @@ describe BatchOperation, type: :model do
context 'when it succeed' do
it 'pushes dossier_job id to batch_operation.success_dossier_ids' do
expect { batch_operation.track_processed_dossier(true, dossier) }
.to change { batch_operation.reload.success_dossier_ids }
.to change { batch_operation.dossier_operations.success.pluck(:dossier_id) }
.from([])
.to([dossier.id])
end
end
context 'when it succeed after a failure' do
let(:batch_operation) { create(:batch_operation, operation: :archiver, instructeur: instructeur, dossiers: [dossier], failed_dossier_ids: [dossier.id]) }
let(:batch_operation) { create(:batch_operation, operation: :archiver, instructeur: instructeur, dossiers: [dossier]) }
before do
batch_operation.track_processed_dossier(false, dossier)
end
it 'remove former dossier id from failed_dossier_ids' do
expect { batch_operation.track_processed_dossier(true, dossier) }
.to change { batch_operation.reload.failed_dossier_ids }
.to change { batch_operation.dossier_operations.error.pluck(:dossier_id) }
.from([dossier.id])
.to([])
end
@ -75,7 +76,7 @@ describe BatchOperation, type: :model do
context 'when it fails' do
it 'pushes dossier_job id to batch_operation.failed_dossier_ids' do
expect { batch_operation.track_processed_dossier(false, dossier) }
.to change { batch_operation.reload.failed_dossier_ids }
.to change { batch_operation.dossier_operations.error.pluck(:dossier_id) }
.from([])
.to([dossier.id])
end