DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

tech(APIBretagneService.clean): renvoie un tableau vide tant que la recherche ne fait pas plus de 2 caractères

Browse source
This commit is contained in:
Martin 2023-10-19 08:47:48 +02:00
parent 857c1f0c21
commit 3495147045
1 changed files with 3 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/services/api_bretagne_service.rb
View file

@ -14,16 +14,19 @@ class APIBretagneService
def search_domaine_fonct(code_or_label: "") def search_domaine_fonct(code_or_label: "")
url = build_url(ENDPOINTS.fetch('domaine-fonct')) url = build_url(ENDPOINTS.fetch('domaine-fonct'))
return [] if code_or_label.size < 3
fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || [] fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || []
end end
def search_centre_couts(code_or_label: "") def search_centre_couts(code_or_label: "")
url = build_url(ENDPOINTS.fetch('centre-couts')) url = build_url(ENDPOINTS.fetch('centre-couts'))
return [] if code_or_label.size < 3
fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || [] fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || []
end end
def search_ref_programmation(code_or_label: "") def search_ref_programmation(code_or_label: "")
url = build_url(ENDPOINTS.fetch('ref-programmation')) url = build_url(ENDPOINTS.fetch('ref-programmation'))
return [] if code_or_label.size < 3
fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || [] fetch_page(url:, params: { query: code_or_label, page_number: 1 })[:items] || []
end end
@ -46,22 +49,6 @@ class APIBretagneService
end end
end end
# QUESTION TECH, on a des API av 18k reponse potentielles,
# sur de l'autocomplete je suppose qu'on cherche pas a paginer le resultat.
# vous avez une autre idée en tête ?
# def fetch_all_page(url:, code_or_label:)
# first_page = fetch_page(url:, params: { page_number: 1, query: code_or_label })
# return [] if first_page.empty?
# total_pages = (first_page[:pageInfo][:totalRows].to_f / first_page[:pageInfo][:pageSize].to_f).ceil
# all = first_page[:items]
# (2..total_pages).map do |page_number|
# page = fetch_page(url:, params: { page_number: })
# all.concat(page[:items])
# end
# all
# end
def call(url:, params:) def call(url:, params:)
API::Client.new.(url:, params:, authorization_token:, method:) API::Client.new.(url:, params:, authorization_token:, method:)