chore(vite): do not use legacy build in development

app/helpers/application_helper.rb

@@ -181,4 +181,12 @@ module ApplicationHelper
   def show_outdated_browser_banner?
     !supported_browser? && !has_dismissed_outdated_browser_banner?
   end
+
+  def vite_legacy?
+    if ENV['VITE_LEGACY'] == 'disabled'
+      false
+    else
+      Rails.env.production? || ENV['VITE_LEGACY'] == 'enabled'
+    end
+  end
 end

app/views/layouts/application.html.haml

@@ -43,7 +43,8 @@
       - if content_for?(:footer)
         = content_for(:footer)
 
-      = vite_legacy_javascript_tag 'application'
+      - if vite_legacy?
+        = vite_legacy_javascript_tag 'application'
 
       = yield :charts_js
 

config/env.example.optional

@@ -133,3 +133,7 @@ SENDINBLUE_BALANCING_VALUE="50"
 DOLIST_BALANCING_VALUE="50"
 # Used only by a migration to choose your default regarding procedure archive dossiers after duree_conservation_dossiers_dans_ds
 # DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true
+
+# Enable vite legacy build (IE11). Legacy build is used in production (except if set to "disabled").
+# You might want to enable it in other environements for testing. Build time will be greatly impacted.
+VITE_LEGACY=""

vite.config.ts

@@ -4,27 +4,17 @@ import ViteLegacy from '@vitejs/plugin-legacy';
 import FullReload from 'vite-plugin-full-reload';
 import RubyPlugin from 'vite-plugin-ruby';
 
-export default defineConfig({
+const plugins = [
-  resolve: { alias: { '@utils': '/shared/utils.ts' } },
+  RubyPlugin(),
-  build: {
+  ViteReact({
-    sourcemap: true,
+    parserPlugins: ['classProperties', 'classPrivateProperties'],
-    rollupOptions: {
+    jsxRuntime: 'classic'
-      output: {
+  }),
-        manualChunks(id) {
+  FullReload(['config/routes.rb', 'app/views/**/*'], { delay: 200 })
-          if (id.match('maplibre') || id.match('mapbox')) {
+];
-            return 'maplibre';
+
-          }
+if (shouldBuildLegacy()) {
-        }
+  plugins.push(
-      }
-    }
-  },
-  plugins: [
-    RubyPlugin(),
-    ViteReact({
-      parserPlugins: ['classProperties', 'classPrivateProperties'],
-      jsxRuntime: 'classic'
-    }),
-    FullReload(['config/routes.rb', 'app/views/**/*'], { delay: 200 }),
     ViteLegacy({
       targets: [
         'defaults',
@@ -48,5 +38,32 @@ export default defineConfig({
         'yet-another-abortcontroller-polyfill'
       ]
     })
-  ]
+  );
+}
+
+export default defineConfig({
+  resolve: { alias: { '@utils': '/shared/utils.ts' } },
+  build: {
+    sourcemap: true,
+    rollupOptions: {
+      output: {
+        manualChunks(id) {
+          if (id.match('maplibre') || id.match('mapbox')) {
+            return 'maplibre';
+          }
+        }
+      }
+    }
+  },
+  plugins
 });
+
+function shouldBuildLegacy() {
+  if (process.env.VITE_LEGACY == 'disabled') {
+    return false;
+  }
+  return (
+    process.env.RAILS_ENV == 'production' ||
+    process.env.VITE_LEGACY == 'enabled'
+  );
+}