fix(footer): add missing a11y external link attributes

app/views/users/_procedure_footer.html.haml

@@ -33,7 +33,7 @@
             %ul.fr-footer__top-list
               - politiques.each do |politique|
                 %li
-                  = link_to t("users.procedure_footer.legals.data_retention_url"), class: "fr-footer__top-link" do
+                  = link_to t("users.procedure_footer.legals.data_retention_url"), class: "fr-footer__top-link", title: new_tab_suffix(t("users.procedure_footer.legals.data_retention_title")), **external_link_attributes do
                     = politique
               - if procedure.deliberation.attached?
                 %li
@@ -53,7 +53,7 @@
           %h3.fr-footer__top-cat= I18n.t('users.procedure_footer.dematerialisation.header')
           %ul.fr-footer__top-list
             %li
-              = link_to t('users.procedure_footer.dematerialisation.title_1'), commencer_dossier_vide_for_revision_path(procedure.active_revision), rel: 'noopener', class: 'fr-footer__top-link'
+              = link_to t('users.procedure_footer.dematerialisation.title_1'), commencer_dossier_vide_for_revision_path(procedure.active_revision), class: 'fr-footer__top-link'
             %li
               = link_to t('users.procedure_footer.dematerialisation.title_2'), t('users.procedure_footer.dematerialisation.link'), class: 'fr-footer__top-link', title: new_tab_suffix(t("users.procedure_footer.dematerialisation.title_2")), **external_link_attributes
 

config/locales/views/users/procedure_footer/en.yml

@@ -18,6 +18,7 @@ en:
       legals:
         header: "Legals :"
         data_retention: "%{application_name} : %{duree_conservation_dossiers_dans_ds} months"
+        data_retention_title: "Explanation of our data retention and archiving policy"
         terms: "Laws regarding this data collection"
         dpo: "Contact the Data Protection Officer"
       dematerialisation: 

config/locales/views/users/procedure_footer/fr.yml

@@ -19,6 +19,7 @@ fr:
         header: "Cadre juridique"
         data_retention: "%{application_name} : %{duree_conservation_dossiers_dans_ds} mois"
         data_retention_url: "https://doc.demarches-simplifiees.fr/pour-aller-plus-loin/archivage-longue-duree-des-demarches"
+        data_retention_title: "Explications sur notre politique de rétention et d’archivage des données"
         terms: "Texte cadrant la demande d’information"
         dpo: "Contacter le Délégué à la Protection des Données"
       official_links: