DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

clean(deadcode): their is no column for avis.label. so clean this one

Browse source
This commit is contained in:
mfo 2024-09-24 20:16:47 +02:00
parent cae524b6bd
commit 284bdc5b2b
No known key found for this signature in database
GPG key ID: 7CE3E1F5B794A8EC
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/models/procedure_presentation.rb
View file

@ -240,22 +240,17 @@ class ProcedurePresentation < ApplicationRecord
dossiers dossiers
.includes(:followers_instructeurs) .includes(:followers_instructeurs)
.joins('INNER JOIN users instructeurs_users ON instructeurs_users.id = instructeurs.user_id') .joins('INNER JOIN users instructeurs_users ON instructeurs_users.id = instructeurs.user_id')
.filter_ilike('instructeurs_users', :email, values) .filter_ilike('instructeurs_users', :email, values) # ilike OK, user may want to search by *@domain
when 'user', 'individual', 'avis' when 'user', 'individual' # user_columns: [email], individual_columns: ['nom', 'prenom', 'gender']
dossiers dossiers
.includes(table) .includes(table)
.filter_ilike(table, column, values) .filter_ilike(table, column, values) # ilike or where column == 'value' are both valid, we opted for ilike
when 'groupe_instructeur' when 'groupe_instructeur'
assert_supported_column(table, column) assert_supported_column(table, column)
if column == 'label'
dossiers
.joins(:groupe_instructeur)
.filter_ilike(table, column, values)
else
dossiers dossiers
.joins(:groupe_instructeur) .joins(:groupe_instructeur)
.where(groupe_instructeur_id: values) .where(groupe_instructeur_id: values)
end
end.pluck(:id) end.pluck(:id)
end end
end.reduce(:&) end.reduce(:&)