DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(email_validation): use truemail regexp

Browse source
This commit is contained in:
Martin 2024-03-12 11:12:30 +01:00
parent d9b6db8ebc
commit 2468d528fd
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/validators/strict_email_validator.rb
View file

@ -3,7 +3,11 @@ class StrictEmailValidator < ActiveModel::EachValidator
# saying that it's quite permissive # saying that it's quite permissive
# but we want more, we want to ensure it's a domain with extension # but we want more, we want to ensure it's a domain with extension
# so we append \.[A-Za-z]{2,} # so we append \.[A-Za-z]{2,}
REGEXP = /\A(?<username>[^@[:space:]])+@(?<domain>[^@[:space:]\.])+(?<extensions>\.[[:alnum:].]{2,})\z/ TRUEMAIL_REGEX_DOMAIN = /[\p{L}0-9]+([-.]{1}[\p{L}\p{N}\p{Pd}]*[\p{L}\p{N}]+)*\.\p{L}{2,63}/i.freeze
TRUEMAIL_REGEX_EMAIL_PATTERN = %r{(?=\A.{6,255}\z)(\A([\p{L}0-9]+[\w\p{L}.+!~,'&%#*^`{}|\-/?=$]*)@(#{TRUEMAIL_REGEX_DOMAIN})\z)}.freeze
REGEXP = TRUEMAIL_REGEX_EMAIL_PATTERN
DATE_SINCE_STRICT_EMAIL_VALIDATION = Date.parse(ENV.fetch('STRICT_EMAIL_VALIDATION_STARTS_ON')) rescue 0 DATE_SINCE_STRICT_EMAIL_VALIDATION = Date.parse(ENV.fetch('STRICT_EMAIL_VALIDATION_STARTS_ON')) rescue 0
def validate_each(record, attribute, value) def validate_each(record, attribute, value)

5
spec/models/champs/email_champ_spec.rb
View file

@ -60,6 +60,11 @@ describe Champs::EmailChamp do
it { is_expected.to be_truthy } it { is_expected.to be_truthy }
end end
context 'when value includes accents' do
let(:value) { 'prenom.nom@etu.univ-rouen.fr' }
it { is_expected.to be_truthy }
end
context 'when value is the classic standard user@domain.ext' do context 'when value is the classic standard user@domain.ext' do
let(:value) { 'username@mailserver.domain' } let(:value) { 'username@mailserver.domain' }
it { is_expected.to be_truthy } it { is_expected.to be_truthy }