DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Code review: cleanup code

Browse source
This commit is contained in:
Guillaume Lazzara 2016-02-19 14:12:06 +01:00
parent 15ac9f3f45
commit 22c1eca61e
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/controllers/admin/gestionnaires_controller.rb
View file

@ -12,12 +12,11 @@ class Admin::GestionnairesController < AdminController
def create def create
gestionnaire_params = create_gestionnaire_params @gestionnaire = Gestionnaire.create(create_gestionnaire_params)
@gestionnaire = Gestionnaire.create(gestionnaire_params)
if @gestionnaire.errors.messages.empty? if @gestionnaire.errors.messages.empty?
flash.notice = 'Gestionnaire ajouté' flash.notice = 'Gestionnaire ajouté'
GestionnaireMailer.new_gestionnaire(gestionnaire_params[:email], gestionnaire_params[:password]).deliver_now! GestionnaireMailer.new_gestionnaire(@gestionnaire.email, @gestionnaire.password).deliver_now!
else else
flash.alert = @gestionnaire.errors.full_messages.join('<br />').html_safe flash.alert = @gestionnaire.errors.full_messages.join('<br />').html_safe
end end

2
app/models/cerfa.rb
View file

@ -2,7 +2,7 @@ class Cerfa < ActiveRecord::Base
belongs_to :dossier belongs_to :dossier
mount_uploader :content, CerfaUploader mount_uploader :content, CerfaUploader
validates :content, :file_size => { :maximum => 3.megabytes.to_i } validates :content, :file_size => { :maximum => 3.megabytes }
def empty? def empty?
content.blank? content.blank?

2
app/models/piece_justificative.rb
View file

@ -7,7 +7,7 @@ class PieceJustificative < ActiveRecord::Base
alias_attribute :type, :type_de_piece_justificative_id alias_attribute :type, :type_de_piece_justificative_id
mount_uploader :content, PieceJustificativeUploader mount_uploader :content, PieceJustificativeUploader
validates :content, :file_size => { :maximum => 3.megabytes.to_i } validates :content, :file_size => { :maximum => 3.megabytes }
def empty? def empty?
content.blank? content.blank?