DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(helpscout): rate limit take into deletions into account

Browse source
This commit is contained in:
Colin Darie 2024-06-25 16:45:41 +02:00
parent 828c539469
commit 22a4f471e5
No known key found for this signature in database
GPG key ID: 4FB865FDBCA4BCC4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/tasks/maintenance/helpscout_delete_old_conversations_task.rb
View file

@ -14,7 +14,7 @@ module Maintenance
throttle_on do throttle_on do
limit = Rails.cache.read(Helpscout::API::RATELIMIT_KEY) limit = Rails.cache.read(Helpscout::API::RATELIMIT_KEY)
limit.present? && limit == 0 limit.present? && limit <= 26 # check is made after each page (of 25 elements), and we need 25 calls to delete them all
end end
def count def count
@ -35,7 +35,7 @@ module Maintenance
# "number" is the current page (always 1 in our case) # "number" is the current page (always 1 in our case)
# iterate until there are no remaining pages # iterate until there are no remaining pages
break if pagination[:totalPages] == pagination[:number] break if pagination[:totalPages] == 0 || pagination[:totalPages] == pagination[:number]
end end
end end
end end