DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(archives): purge stuck pending archives

Browse source 
Cf 0cb096b3d6440a4da05ca2902ed6fa72a93e6579
This commit is contained in:
Colin Darie 2022-07-27 10:32:54 +02:00
parent f1957e51f8
commit 197fa54ea4
3 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/jobs/cron/purge_stale_archives_job.rb
View file

@ -3,5 +3,6 @@ class Cron::PurgeStaleArchivesJob < Cron::CronJob
def perform def perform
Archive.stale(Archive::RETENTION_DURATION).destroy_all Archive.stale(Archive::RETENTION_DURATION).destroy_all
Archive.stuck(Archive::MAX_DUREE_GENERATION).destroy_all
end end
end end

1
app/models/archive.rb
View file

@ -14,6 +14,7 @@ class Archive < ApplicationRecord
include TransientModelsWithPurgeableJobConcern include TransientModelsWithPurgeableJobConcern
RETENTION_DURATION = 4.days RETENTION_DURATION = 4.days
MAX_DUREE_GENERATION = 24.hours
MAX_SIZE = 100.gigabytes MAX_SIZE = 100.gigabytes
has_and_belongs_to_many :groupe_instructeurs has_and_belongs_to_many :groupe_instructeurs

28
spec/models/archive_spec.rb
View file

@ -4,26 +4,34 @@ describe Archive do
before { Timecop.freeze(Time.zone.now) } before { Timecop.freeze(Time.zone.now) }
after { Timecop.return } after { Timecop.return }
let(:archive) { create(:archive, job_status: :pending) } let!(:archive) { create(:archive, job_status: :pending) }
describe 'scopes' do describe 'scopes' do
describe 'staled' do describe 'staled' do
let(:recent_archive) { create(:archive, job_status: :pending) } let!(:recent_archive) { create(:archive, job_status: :pending) }
let(:staled_archive_still_pending) { create(:archive, job_status: :pending, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) } let!(:staled_archive_still_pending) { create(:archive, job_status: :pending, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) }
let(:staled_archive_still_failed) { create(:archive, job_status: :failed, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) } let!(:staled_archive_still_failed) { create(:archive, job_status: :failed, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) }
let(:staled_archive_still_generated) { create(:archive, job_status: :generated, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) } let!(:staled_archive_still_generated) { create(:archive, job_status: :generated, updated_at: (Archive::RETENTION_DURATION + 2).days.ago) }
subject do subject do
archive
recent_archive
staled_archive_still_pending
staled_archive_still_failed
staled_archive_still_generated
Archive.stale(Archive::RETENTION_DURATION) Archive.stale(Archive::RETENTION_DURATION)
end end
it { is_expected.to match_array([staled_archive_still_failed, staled_archive_still_generated]) } it { is_expected.to match_array([staled_archive_still_failed, staled_archive_still_generated]) }
end end
describe 'stuck' do
let!(:recent_archive) { create(:archive, job_status: :pending) }
let!(:staled_archive_still_pending) { create(:archive, job_status: :pending, updated_at: (Archive::MAX_DUREE_GENERATION + 2).days.ago) }
let!(:staled_archive_still_failed) { create(:archive, job_status: :failed, updated_at: (Archive::MAX_DUREE_GENERATION + 2).days.ago) }
let!(:staled_archive_still_generated) { create(:archive, job_status: :generated, updated_at: (Archive::MAX_DUREE_GENERATION + 2).days.ago) }
subject do
Archive.stuck(Archive::MAX_DUREE_GENERATION)
end
it { is_expected.to match_array([staled_archive_still_pending]) }
end
end end
describe '.job_status' do describe '.job_status' do