Refactor Backoffice::DossiersController#process_dossier

app/controllers/backoffice/dossiers_controller.rb

@@ -104,63 +104,33 @@ class Backoffice::DossiersController < Backoffice::DossiersListController
   end
 
   def process_dossier
+    create_dossier_facade params[:dossier_id]
+
+    if params[:dossier] && params[:dossier][:motivation].present?
+      motivation = params[:dossier][:motivation]
+    end
+
+    dossier = @facade.dossier
+
     case params[:process_action]
     when "refuse"
-      refuse
+      next_step = "refuse"
+      notice = "Dossier considéré comme refusé."
+      template = dossier.procedure.refused_mail_template
     when "without_continuation"
-      without_continuation
+      next_step = "without_continuation"
+      notice = "Dossier considéré comme sans suite."
+      template = dossier.procedure.without_continuation_mail_template
     when "close"
-      close
+      next_step = "close"
-    end
+      notice = "Dossier traité avec succès."
-  end
+      template = dossier.procedure.closed_mail_template
-
-  def refuse
-    create_dossier_facade params[:dossier_id]
-
-    if params[:dossier] && params[:dossier][:motivation].present?
-      motivation = params[:dossier][:motivation]
     end
 
-    dossier = @facade.dossier
+    dossier.next_step! 'gestionnaire', next_step, motivation
+    flash.notice = notice
 
-    dossier.next_step! 'gestionnaire', 'refuse', motivation
+    NotificationMailer.send_notification(dossier, template).deliver_now!
-    flash.notice = 'Dossier considéré comme refusé.'
-
-    NotificationMailer.send_notification(dossier, dossier.procedure.refused_mail_template).deliver_now!
-
-    redirect_to backoffice_dossier_path(id: dossier.id)
-  end
-
-  def without_continuation
-    create_dossier_facade params[:dossier_id]
-
-    if params[:dossier] && params[:dossier][:motivation].present?
-      motivation = params[:dossier][:motivation]
-    end
-
-    dossier = @facade.dossier
-
-    dossier.next_step! 'gestionnaire', 'without_continuation', motivation
-    flash.notice = 'Dossier considéré comme sans suite.'
-
-    NotificationMailer.send_notification(dossier, dossier.procedure.without_continuation_mail_template).deliver_now!
-
-    redirect_to backoffice_dossier_path(id: dossier.id)
-  end
-
-  def close
-    create_dossier_facade params[:dossier_id]
-
-    if params[:dossier] && params[:dossier][:motivation].present?
-      motivation = params[:dossier][:motivation]
-    end
-
-    dossier = @facade.dossier
-
-    dossier.next_step! 'gestionnaire', 'close', motivation
-    flash.notice = 'Dossier traité avec succès.'
-
-    NotificationMailer.send_notification(dossier, dossier.procedure.closed_mail_template).deliver_now!
 
     redirect_to backoffice_dossier_path(id: dossier.id)
   end

spec/controllers/backoffice/dossiers_controller_spec.rb

@@ -251,112 +251,85 @@ describe Backoffice::DossiersController, type: :controller do
   end
 
   describe 'POST #process_dossier' do
-    before do
-      dossier.received!
-      sign_in gestionnaire
-    end
-
     context "with refuse" do
-      it "calls the refuse method" do
+      before do
-        expect(controller).to receive(:refuse)
+        dossier.received!
-
+        sign_in gestionnaire
-        post :process_dossier, params: { dossier_id: dossier_id, process_action: "refuse" }
       end
+
+      subject { post :process_dossier, params: { process_action: "refuse", dossier_id: dossier_id} }
+
+      it 'change state to refused' do
+        subject
+
+        dossier.reload
+        expect(dossier.state).to eq('refused')
+      end
+
+      it 'Notification email is sent' do
+        expect(NotificationMailer).to receive(:send_notification)
+          .with(dossier, kind_of(Mails::RefusedMail)).and_return(NotificationMailer)
+        expect(NotificationMailer).to receive(:deliver_now!)
+
+        subject
+      end
+
+      it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
     end
 
     context "with without_continuation" do
-      it "calls the without_continuation method" do
+      before do
-        expect(controller).to receive(:without_continuation)
+        dossier.received!
-
+        sign_in gestionnaire
-        post :process_dossier, params: { dossier_id: dossier_id, process_action: "without_continuation" }
       end
+
+      subject { post :process_dossier, params: { process_action: "without_continuation", dossier_id: dossier_id} }
+
+      it 'change state to without_continuation' do
+        subject
+
+        dossier.reload
+        expect(dossier.state).to eq('without_continuation')
+      end
+
+      it 'Notification email is sent' do
+        expect(NotificationMailer).to receive(:send_notification)
+          .with(dossier, kind_of(Mails::WithoutContinuationMail)).and_return(NotificationMailer)
+        expect(NotificationMailer).to receive(:deliver_now!)
+
+        subject
+      end
+
+      it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
     end
 
     context "with close" do
-      it "calls the close method" do
+      before do
-        expect(controller).to receive(:close)
+        dossier.received!
-
+        sign_in gestionnaire
-        post :process_dossier, params: { dossier_id: dossier_id, process_action: "close" }
       end
+
+      subject { post :process_dossier, params: { process_action: "close", dossier_id: dossier_id} }
+
+      it 'change state to closed' do
+        subject
+
+        dossier.reload
+        expect(dossier.state).to eq('closed')
+      end
+
+      it 'Notification email is sent' do
+        expect(NotificationMailer).to receive(:send_notification)
+          .with(dossier, kind_of(Mails::ClosedMail)).and_return(NotificationMailer)
+        expect(NotificationMailer).to receive(:deliver_now!)
+
+        subject
+      end
+
+      it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
     end
   end
 
-  describe 'POST #refuse' do
-    before do
-      dossier.received!
-      sign_in gestionnaire
-    end
-
-    subject { post :refuse, params: {dossier_id: dossier_id} }
-
-    it 'change state to refused' do
-      subject
-
-      dossier.reload
-      expect(dossier.state).to eq('refused')
-    end
-
-    it 'Notification email is sent' do
-      expect(NotificationMailer).to receive(:send_notification)
-        .with(dossier, kind_of(Mails::RefusedMail)).and_return(NotificationMailer)
-      expect(NotificationMailer).to receive(:deliver_now!)
-
-      subject
-    end
-
-    it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
-  end
-
-  describe 'POST #without_continuation' do
-    before do
-      dossier.received!
-      sign_in gestionnaire
-    end
-    subject { post :without_continuation, params: {dossier_id: dossier_id} }
-
-    it 'change state to without_continuation' do
-      subject
-
-      dossier.reload
-      expect(dossier.state).to eq('without_continuation')
-    end
-
-    it 'Notification email is sent' do
-      expect(NotificationMailer).to receive(:send_notification)
-        .with(dossier, kind_of(Mails::WithoutContinuationMail)).and_return(NotificationMailer)
-      expect(NotificationMailer).to receive(:deliver_now!)
-
-      subject
-    end
-
-    it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
-  end
-
-  describe 'POST #close' do
-    before do
-      dossier.received!
-      sign_in gestionnaire
-    end
-    subject { post :close, params: {dossier_id: dossier_id} }
-
-    it 'change state to closed' do
-      subject
-
-      dossier.reload
-      expect(dossier.state).to eq('closed')
-    end
-
-    it 'Notification email is sent' do
-      expect(NotificationMailer).to receive(:send_notification)
-        .with(dossier, kind_of(Mails::ClosedMail)).and_return(NotificationMailer)
-      expect(NotificationMailer).to receive(:deliver_now!)
-
-      subject
-    end
-
-    it { is_expected.to redirect_to backoffice_dossier_path(id: dossier.id) }
-  end
-
   describe 'PUT #toggle_follow' do
     before do
       sign_in gestionnaire