Activate device email change confirmation

config/initializers/devise.rb

@@ -121,7 +121,7 @@ Devise.setup do |config|
   # initial account confirmation) to be applied. Requires additional unconfirmed_email
   # db field (see migrations). Until confirmed, new email is stored in
   # unconfirmed_email column, and copied to email column on successful confirmation.
-  config.reconfirmable = false
+  config.reconfirmable = true
 
   # Defines which key will be used when confirming an account
   # config.confirmation_keys = [ :email ]

db/migrate/20190704133749_add_unconfirmed_email_column_to_users.rb

@@ -0,0 +1,5 @@
+class AddUnconfirmedEmailColumnToUsers < ActiveRecord::Migration[5.2]
+  def change
+    add_column :users, :unconfirmed_email, :text
+  end
+end

db/schema.rb

@@ -605,6 +605,7 @@ ActiveRecord::Schema.define(version: 2019_07_04_144304) do
     t.string "confirmation_token"
     t.datetime "confirmed_at"
     t.datetime "confirmation_sent_at"
+    t.text "unconfirmed_email"
     t.index ["confirmation_token"], name: "index_users_on_confirmation_token", unique: true
     t.index ["email"], name: "index_users_on_email", unique: true
     t.index ["reset_password_token"], name: "index_users_on_reset_password_token", unique: true

spec/features/admin/connection_spec.rb

@@ -6,6 +6,7 @@ feature 'Administrator connection' do
   let(:email) { 'admin1@admin.com' }
   let(:password) { 'mon chien aime les bananes' }
   let!(:admin) { create(:administrateur, :with_procedure, email: email, password: password) }
+  let!(:user) { create(:user, email: email, password: password) }
 
   before do
     Flipflop::FeatureSet.current.test!.switch!(:enable_email_login_token, true)

spec/models/user_spec.rb

@@ -107,6 +107,7 @@ describe User, type: :model do
       gestionnaire = create(:gestionnaire, email: user.email)
 
       user.update(email: 'whoami@plop.com', password: 'super secret')
+      user.confirm
 
       gestionnaire.reload
       expect(gestionnaire.email).to eq('whoami@plop.com')
@@ -118,6 +119,7 @@ describe User, type: :model do
       admin = create(:administrateur, email: user.email)
 
       user.update(email: 'whoami@plop.com', password: 'super secret')
+      user.confirm
 
       admin.reload
       expect(admin.email).to eq('whoami@plop.com')