DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

bug(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes

Browse source
This commit is contained in:
Martin 2024-03-08 15:46:11 +01:00
parent 1024557081
commit 0e54ca314d
1 changed files with 24 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
spec/controllers/users/dossiers_controller_spec.rb
View file

@ -515,8 +515,9 @@ describe Users::DossiersController, type: :controller do
describe '#submit_en_construction' do describe '#submit_en_construction' do
before { sign_in(user) } before { sign_in(user) }
let(:procedure) { create(:procedure, :published, types_de_champ_public:) }
let!(:dossier) { create(:dossier, :en_construction, user: user) } let(:types_de_champ_public) { [{ type: :text }] }
let(:dossier) { create(:dossier, :en_construction, procedure:, user:) }
let(:first_champ) { dossier.owner_editing_fork.champs_public.first } let(:first_champ) { dossier.owner_editing_fork.champs_public.first }
let(:anchor_to_first_champ) { controller.helpers.link_to I18n.t('views.users.dossiers.fix_champ'), modifier_dossier_path(anchor: first_champ.labelledby_id), class: 'error-anchor' } let(:anchor_to_first_champ) { controller.helpers.link_to I18n.t('views.users.dossiers.fix_champ'), modifier_dossier_path(anchor: first_champ.labelledby_id), class: 'error-anchor' }
let(:value) { 'beautiful value' } let(:value) { 'beautiful value' }
@ -560,10 +561,8 @@ describe Users::DossiersController, type: :controller do
context 'when a mandatory champ is missing' do context 'when a mandatory champ is missing' do
let(:value) { nil } let(:value) { nil }
render_views render_views
before do let(:types_de_champ_public) { [{ type: :text, mandatory: true, libelle: 'l' }] }
first_champ.type_de_champ.update(mandatory: true, libelle: 'l') before { subject }
subject
end
it { expect(response).to render_template(:modifier) } it { expect(response).to render_template(:modifier) }
it { expect(response.body).to have_content("doit être rempli") } it { expect(response.body).to have_content("doit être rempli") }
@ -580,6 +579,25 @@ describe Users::DossiersController, type: :controller do
end end
end end
context 'when dossier repetition had been removed in newer version' do
let(:dossier) { create(:dossier, :en_construction, :with_populated_champs, procedure:, user:) }
let(:types_de_champ_public) { [{ type: :repetition, libelle: 'repetition', children: [{ type: :text, libelle: 'child' }] }] }
let(:editing_fork) { dossier.owner_editing_fork }
let(:champ_repetition) { editing_fork.champs.find(&:repetition?) }
before do
editing_fork
procedure.draft_revision.remove_type_de_champ(editing_fork.champs.find(&:repetition?).stable_id)
procedure.publish_revision!
editing_fork.reload
editing_fork.rebase!
end
let(:submit_payload) { { id: dossier.id } }
it { expect { subject }.not_to raise_error }
end
context 'when dossier was already submitted' do context 'when dossier was already submitted' do
before { post :submit_en_construction, params: payload } before { post :submit_en_construction, params: payload }