Enable the Lint/UselessAssignment cop

.rubocop.yml

@@ -486,7 +486,9 @@ Lint/UselessAccessModifier:
   Enabled: false
 
 Lint/UselessAssignment:
-  Enabled: false
+  Enabled: true
+  Exclude:
+    - "spec/**/*"
 
 Lint/UselessComparison:
   Enabled: true

app/services/pieces_justificatives_service.rb

@@ -10,7 +10,7 @@ class PiecesJustificativesService
     errors = with_virus
       .map { |_, content| "#{content.original_filename} : virus détecté" }
 
-    errors += without_virus
+    errors + without_virus
       .map { |tpj, content| save_pj(content, dossier, tpj, user) }
       .compact()
   end

app/services/procedure_export_service.rb

@@ -212,7 +212,8 @@ class ProcedureExportService
         etablissement.champ.dossier_id,
         label_for_export(etablissement.champ.libelle).to_s
       ]
-      data += etablissement_data(etablissement)
+
+      data + etablissement_data(etablissement)
     end
   end
 

lib/tasks/2018_09_12_fix_templates.rake

@@ -2,7 +2,7 @@ namespace :'2018_09_12_fix_templates' do
   task run: :environment do
     dossiers_with_invalid_attestations = find_dossiers_with_sent_and_invalid_attestations
     fix_templates
-    fixed_attestations = delete_then_regenerate_attestations(dossiers_with_invalid_attestations)
+    delete_then_regenerate_attestations(dossiers_with_invalid_attestations)
     send_regenerated_attestations(dossiers_with_invalid_attestations)
   end