Merge pull request #7104 from betagouv/US/fix-archive-write-append-binary-with-string

fix(parallel_download_queue): appending content to file in chunk leads to some corrupted files.

app/lib/download_manager/parallel_download_queue.rb

@@ -36,11 +36,12 @@ module DownloadManager
         File.write(attachment_path, attachment.file.read, mode: 'wb')
       else
         request = Typhoeus::Request.new(attachment.url)
-        request.on_body do |chunk|
-          File.write(attachment_path, chunk, mode: 'a+b')
-        end
         request.on_complete do |response|
-          unless response.success?
+          if response.success?
+            File.open(attachment_path, mode: "wb") do |fd|
+              fd.write(response.body)
+            end
+          else
             File.delete(attachment_path) if File.exist?(attachment_path) # -> case of retries failed, must cleanup partialy downloaded file
             on_error.call(attachment, path_in_download_dir, response.code)
           end