Make MailTemplateConcern.slug a constant

app/controllers/admin/mail_templates_controller.rb

@@ -29,7 +29,7 @@ class Admin::MailTemplatesController < AdminController
   end
 
   def find_mail_template_by_slug(slug)
-    mails.find { |m| m.class.slug == slug }
+    mails.find { |m| m.class.const_get(:SLUG) == slug }
   end
 
   def update_params

app/models/concerns/mail_template_concern.rb

@@ -37,10 +37,6 @@ module MailTemplateConcern
   end
 
   module ClassMethods
-    def slug
-      self.name.demodulize.underscore.parameterize
-    end
-
     def default
       body = ActionController::Base.new.render_to_string(template: self.name.underscore)
       self.new(object: self.const_get(:DEFAULT_OBJECT), body: body)

app/models/mails/closed_mail.rb

@@ -2,6 +2,7 @@ module Mails
   class ClosedMail < ApplicationRecord
     include MailTemplateConcern
 
+    SLUG = "closed_mail"
     DISPLAYED_NAME = "Accusé d'acceptation"
     DEFAULT_OBJECT = 'Votre dossier TPS nº --numero_dossier-- a été accepté'
     ALLOWED_TAGS = [TAG_NUMERO_DOSSIER, TAG_LIEN_DOSSIER, TAG_LIBELLE_PROCEDURE, TAG_DATE_DE_DECISION]

app/models/mails/initiated_mail.rb

@@ -2,6 +2,7 @@ module Mails
   class InitiatedMail < ApplicationRecord
     include MailTemplateConcern
 
+    SLUG = "initiated_mail"
     DISPLAYED_NAME = 'Accusé de réception'
     DEFAULT_OBJECT = 'Votre dossier TPS nº --numero_dossier-- a été bien reçu'
     ALLOWED_TAGS = [TAG_NUMERO_DOSSIER, TAG_LIEN_DOSSIER, TAG_LIBELLE_PROCEDURE]

app/models/mails/received_mail.rb

@@ -2,6 +2,7 @@ module Mails
   class ReceivedMail < ApplicationRecord
     include MailTemplateConcern
 
+    SLUG = "received_mail"
     DISPLAYED_NAME = 'Accusé de passage en instruction'
     DEFAULT_OBJECT = 'Votre dossier TPS nº --numero_dossier-- va être instruit'
     ALLOWED_TAGS = [TAG_NUMERO_DOSSIER, TAG_LIEN_DOSSIER, TAG_LIBELLE_PROCEDURE]

app/models/mails/refused_mail.rb

@@ -2,6 +2,7 @@ module Mails
   class RefusedMail < ApplicationRecord
     include MailTemplateConcern
 
+    SLUG = "refused_mail"
     DISPLAYED_NAME = 'Accusé de rejet du dossier'
     DEFAULT_OBJECT = 'Votre dossier TPS nº --numero_dossier-- a été refusé'
     ALLOWED_TAGS = [TAG_NUMERO_DOSSIER, TAG_LIEN_DOSSIER, TAG_LIBELLE_PROCEDURE, TAG_DATE_DE_DECISION]

app/models/mails/without_continuation_mail.rb

@@ -2,6 +2,7 @@ module Mails
   class WithoutContinuationMail < ApplicationRecord
     include MailTemplateConcern
 
+    SLUG = "without_continuation"
     DISPLAYED_NAME = 'Accusé de classement sans suite'
     DEFAULT_OBJECT = 'Votre dossier TPS nº --numero_dossier-- a été classé sans suite'
     ALLOWED_TAGS = [TAG_NUMERO_DOSSIER, TAG_LIEN_DOSSIER, TAG_LIBELLE_PROCEDURE, TAG_DATE_DE_DECISION]

app/views/admin/mail_templates/edit.html.haml

@@ -4,7 +4,7 @@
 
   = simple_form_for @mail_template,
     as: 'mail_template',
-    url: admin_procedure_mail_template_path(@procedure, @mail_template.class.slug),
+    url: admin_procedure_mail_template_path(@procedure, @mail_template.class.const_get(:SLUG)),
     method: :put do |f|
     .row
       .col-md-6

app/views/admin/mail_templates/index.html.haml

@@ -10,4 +10,4 @@
           %td
             = mail.class.const_get(:DISPLAYED_NAME)
           %td.text-right
-            = link_to "Personnaliser l'e-mail", edit_admin_procedure_mail_template_path(@procedure, mail.class.slug)
+            = link_to "Personnaliser l'e-mail", edit_admin_procedure_mail_template_path(@procedure, mail.class.const_get(:SLUG))

spec/controllers/admin/mail_templates_controller_spec.rb

@@ -25,7 +25,7 @@ describe Admin::MailTemplatesController, type: :controller do
     before :each do
       patch :update,
         params: { procedure_id: procedure.id,
-                  id: initiated_mail.class.slug,
+                  id: initiated_mail.class.const_get(:SLUG),
                   mail_template: { object: object, body: body }
                 }
     end