DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

france_connect: raise an error if some validation error occurs

Browse source 
If a validation error occurs in `find_or_create`, an object without `id`
will be returned–and the code will crash soon after.

Ensure that we crash immediately, so that we can report the root cause
(the validation error) instead of a seemingly-unrelated crash later.
This commit is contained in:
Pierre de La Morinerie 2019-07-08 17:30:07 +02:00
parent 6b27ac8514
commit 06afc3890f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/france_connect/particulier_controller.rb
View file

@ -13,7 +13,7 @@ class FranceConnect::ParticulierController < ApplicationController
fetched_fci.tap(&:save) fetched_fci.tap(&:save)
if fci.user.nil? if fci.user.nil?
user = User.find_or_create_by(email: fci.email_france_connect.downcase) do |new_user| user = User.find_or_create_by!(email: fci.email_france_connect.downcase) do |new_user|
new_user.password = Devise.friendly_token[0, 20] new_user.password = Devise.friendly_token[0, 20]
new_user.confirmed_at = Time.zone.now new_user.confirmed_at = Time.zone.now
end end