DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #7279 from betagouv/US/fix-export-includes-brouillons

Browse source 
bug(export): expect dossiers_for_export not to include dossiers brouillon
This commit is contained in:
mfo 2022-05-10 16:16:13 +02:00 committed by GitHub
commit 03ef21c103
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/export.rb
View file

@ -159,7 +159,7 @@ class Export < ApplicationRecord
dossiers.where(id: filtered_sorted_ids)
else
dossiers
dossiers.visible_by_administration
end
end
end

20
spec/models/export_spec.rb
View file

@ -53,4 +53,24 @@ RSpec.describe Export, type: :model do
it { expect(Export.find_for_groupe_instructeurs([gi_1.id, gi_2.id, gi_3.id], nil)).to eq({ csv: { statut: {}, time_span_type: {} }, xlsx: { statut: {}, time_span_type: {} }, ods: { statut: {}, time_span_type: {} }, zip: { statut: {}, time_span_type: {} } }) }
end
end
describe '.dossiers_for_export' do
let!(:procedure) { create(:procedure, :published) }
let!(:dossier_brouillon) { create(:dossier, :brouillon, procedure: procedure) }
let!(:dossier_en_construction) { create(:dossier, :en_construction, procedure: procedure) }
let!(:dossier_en_instruction) { create(:dossier, :en_instruction, procedure: procedure) }
let!(:dossier_accepte) { create(:dossier, :accepte, procedure: procedure) }
let(:export) { create(:export, groupe_instructeurs: [procedure.groupe_instructeurs.first]) }
context 'without procedure_presentation or since' do
it 'does not includes brouillons' do
expect(export.send(:dossiers_for_export)).to include(dossier_en_construction)
expect(export.send(:dossiers_for_export)).to include(dossier_en_instruction)
expect(export.send(:dossiers_for_export)).to include(dossier_accepte)
expect(export.send(:dossiers_for_export)).not_to include(dossier_brouillon)
end
end
end
end