added a custom rubocop linter in order to avoid hardcoding application name
This commit is contained in:
parent
c1208add62
commit
03864f60cf
2 changed files with 29 additions and 0 deletions
12
.rubocop.yml
12
.rubocop.yml
|
@ -1,6 +1,7 @@
|
||||||
require:
|
require:
|
||||||
- rubocop/rspec/focused
|
- rubocop/rspec/focused
|
||||||
- ./lib/cops/unscoped.rb
|
- ./lib/cops/unscoped.rb
|
||||||
|
- ./lib/cops/application_name.rb
|
||||||
inherit_gem:
|
inherit_gem:
|
||||||
rubocop-rails_config:
|
rubocop-rails_config:
|
||||||
- config/rails.yml
|
- config/rails.yml
|
||||||
|
@ -12,6 +13,17 @@ AllCops:
|
||||||
- "bin/*"
|
- "bin/*"
|
||||||
- "node_modules/**/*"
|
- "node_modules/**/*"
|
||||||
|
|
||||||
|
DS/Unscoped:
|
||||||
|
Enabled: true
|
||||||
|
|
||||||
|
DS/ApplicationName:
|
||||||
|
Enabled: true
|
||||||
|
Exclude:
|
||||||
|
- './config/application_name.rb'
|
||||||
|
- './lib/cops/application_name.rb'
|
||||||
|
- './lib/linters/application_name_linter.rb'
|
||||||
|
- "./spec/**/*"
|
||||||
|
|
||||||
Bundler/DuplicatedGem:
|
Bundler/DuplicatedGem:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
|
|
17
lib/cops/application_name.rb
Normal file
17
lib/cops/application_name.rb
Normal file
|
@ -0,0 +1,17 @@
|
||||||
|
if defined?(RuboCop)
|
||||||
|
module RuboCop
|
||||||
|
module Cop
|
||||||
|
module DS
|
||||||
|
class ApplicationName < Cop
|
||||||
|
MSG = "Avoid hardcoding `demarches-simplifiees.fr`. Instead use a dedicated environnement variable."
|
||||||
|
|
||||||
|
def on_str(node)
|
||||||
|
return unless node.source.include?('demarches-simplifiees.fr')
|
||||||
|
|
||||||
|
add_offense(node)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
Loading…
Add table
Reference in a new issue