added a custom rubocop linter in order to avoid hardcoding application name

This commit is contained in:
clemkeirua 2020-07-23 16:10:51 +02:00
parent c1208add62
commit 03864f60cf
2 changed files with 29 additions and 0 deletions

View file

@ -1,6 +1,7 @@
require:
- rubocop/rspec/focused
- ./lib/cops/unscoped.rb
- ./lib/cops/application_name.rb
inherit_gem:
rubocop-rails_config:
- config/rails.yml
@ -12,6 +13,17 @@ AllCops:
- "bin/*"
- "node_modules/**/*"
DS/Unscoped:
Enabled: true
DS/ApplicationName:
Enabled: true
Exclude:
- './config/application_name.rb'
- './lib/cops/application_name.rb'
- './lib/linters/application_name_linter.rb'
- "./spec/**/*"
Bundler/DuplicatedGem:
Enabled: true

View file

@ -0,0 +1,17 @@
if defined?(RuboCop)
module RuboCop
module Cop
module DS
class ApplicationName < Cop
MSG = "Avoid hardcoding `demarches-simplifiees.fr`. Instead use a dedicated environnement variable."
def on_str(node)
return unless node.source.include?('demarches-simplifiees.fr')
add_offense(node)
end
end
end
end
end
end