DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

chore(champ): update error catching when fetching external data

Browse source
This commit is contained in:
Eric Leroy-Terquem 2023-10-27 14:16:29 +02:00
parent 234c6e6248
commit 0268b0af9e
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/models/champ.rb
View file

@ -205,9 +205,7 @@ class Champ < ApplicationRecord
end end
def log_fetch_external_data_exception(exception) def log_fetch_external_data_exception(exception)
exceptions = self.fetch_external_data_exceptions ||= [] update_column(:fetch_external_data_exceptions, [exception.inspect])
exceptions << exception.inspect
update_column(:fetch_external_data_exceptions, exceptions)
end end
def fetch_external_data? def fetch_external_data?
@ -218,10 +216,12 @@ class Champ < ApplicationRecord
false false
end end
def fetch_external_data_error?
fetch_external_data_exceptions.present? && self.external_id.present?
end
def fetch_external_data_pending? def fetch_external_data_pending?
# We don't have a good mechanism right now to know if the last fetch has errored. So, in order fetch_external_data? && poll_external_data? && external_id.present? && data.nil? && !fetch_external_data_error?
# to ensure we don't poll to infinity, we stop after 5 minutes no matter what.
fetch_external_data? && poll_external_data? && external_id.present? && data.nil? && updated_at > 5.minutes.ago
end end
def fetch_external_data def fetch_external_data
@ -289,6 +289,7 @@ class Champ < ApplicationRecord
def fetch_external_data_later def fetch_external_data_later
if fetch_external_data? && external_id.present? && data.nil? if fetch_external_data? && external_id.present? && data.nil?
update_column(:fetch_external_data_exceptions, [])
ChampFetchExternalDataJob.perform_later(self, external_id) ChampFetchExternalDataJob.perform_later(self, external_id)
end end
end end