DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Refacto prefill_params construction (remove merge)

Browse source
This commit is contained in:
Damien Le Thiec 2022-12-01 15:05:23 +01:00 • committed by sebastiencarceles
parent 373e8aeadb
commit 006a1257b5
1 changed files with 14 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
app/models/prefill_params.rb
View file

@ -5,43 +5,30 @@ class PrefillParams
end end
def to_a def to_a
# Builds: [{ stable_id: 1, value: "a value" }, { stable_id: 2, value: "another value"}] build_prefill_values.filter(&:prefillable?).map(&:to_h)
stable_ids_and_values = convert_typed_ids_to_stable_ids
# Builds: [{stable_id: "1", champ: #<Champs::...>}, {stable_id: "2", champ: #<Champs::...>}]
stable_ids_and_champs = find_champs(stable_ids_and_values.map { _1[:stable_id] })
# Merges the arrays together, filters out the values we don't want and returns [{ id: champ_1_id, value: value_1}, ...]
merge_by_stable_ids(stable_ids_and_values + stable_ids_and_champs)
.map { PrefillValue.new(champ: _1[:champ], value: _1[:value]) }
.filter(&:prefillable?)
.map(&:to_h)
end end
private private
def convert_typed_ids_to_stable_ids def build_prefill_values
@params # Builds: [{ stable_id: 1, value: "a value" }, { stable_id: 2, value: "another value"}]
.to_unsafe_hash stable_ids_and_values =
.map { |typed_id, value| { stable_id: stable_id_from_typed_id(typed_id), value: value } } @params
.filter { _1[:stable_id].present? && _1[:value].present? } .to_unsafe_hash
end .map { |typed_id, value| { stable_id: stable_id_from_typed_id(typed_id), value: value } }
.filter { _1[:stable_id].present? && _1[:value].present? }
def find_champs(stable_ids)
@dossier @dossier
.find_champs_by_stable_ids(stable_ids) .find_champs_by_stable_ids(stable_ids_and_values.map { _1[:stable_id] })
.map { |champ| { stable_id: champ.stable_id.to_s, champ: champ } } .map do |champ|
end value = stable_ids_and_values.find { _1[:stable_id] == champ.stable_id }[:value]
def merge_by_stable_ids(arrays_of_hashes_with_stable_id) PrefillValue.new(champ: champ, value: value)
arrays_of_hashes_with_stable_id end
.group_by { _1[:stable_id] }
.values
.map { _1.reduce(:merge) }
end end
def stable_id_from_typed_id(typed_id) def stable_id_from_typed_id(typed_id)
Champ.id_from_typed_id(typed_id) Champ.id_from_typed_id(typed_id).to_i
rescue rescue
nil nil
end end