demarches-normaliennes/app/jobs/champ_fetch_external_data_job.rb

class ChampFetchExternalDataJob < ApplicationJob
  def perform(champ, external_id)
    return if champ.external_id != external_id
    return if champ.data.present?
    return if (data = champ.fetch_external_data).blank?

    champ.update_with_external_data!(data: data)
  end
end
Add ChampFetchExternalDataJob 2021-02-09 12:35:23 +01:00			`class ChampFetchExternalDataJob < ApplicationJob`
Try to reduce the number of external data fetches Only fetch external data if the external_id is the current one and data is not yet fetched 2021-03-11 12:32:08 +01:00			`def perform(champ, external_id)`
review: update value with async fetch 1 - spec cover the job which fetches external data 2 - refactor the job with guard clauses 3 - delegate update operation to the champ itself 4 - annuaire education: override the update operation to let the value be populated by the fetched data 5 - prefilling: don't fetch data synchronously 2023-02-28 13:55:52 +01:00			`return if champ.external_id != external_id`
			`return if champ.data.present?`
			`return if (data = champ.fetch_external_data).blank?`
Add ChampFetchExternalDataJob 2021-02-09 12:35:23 +01:00
review: update value with async fetch 1 - spec cover the job which fetches external data 2 - refactor the job with guard clauses 3 - delegate update operation to the champ itself 4 - annuaire education: override the update operation to let the value be populated by the fetched data 5 - prefilling: don't fetch data synchronously 2023-02-28 13:55:52 +01:00			`champ.update_with_external_data!(data: data)`
Add ChampFetchExternalDataJob 2021-02-09 12:35:23 +01:00			`end`
			`end`