demarches-normaliennes/app/jobs/virus_scanner_job.rb

class VirusScannerJob < ApplicationJob
  queue_as :active_storage_analysis

  # If by the time the job runs the blob has been deleted, ignore the error
  discard_on ActiveRecord::RecordNotFound
  # If the file is deleted during the scan, ignore the error
  discard_on ActiveStorage::FileNotFoundError

  # If for some reason the file appears invalid, retry for a while
  retry_on ActiveStorage::IntegrityError, attempts: 10, wait: 5.seconds

  def perform(blob)
    metadata = extract_metadata_via_virus_scanner(blob)
    blob.update!(metadata: blob.metadata.merge(metadata))
  end

  def extract_metadata_via_virus_scanner(blob)
    ActiveStorage::VirusScanner.new(blob).metadata
  end
end
Save virus scan status to blob metadata 2019-05-02 11:37:35 +02:00			`class VirusScannerJob < ApplicationJob`
config: flip config.active_storage.queues ActiveStorage jobs are now moved to their own queue. For consistency, we also move our own analysis jobs (VirusScannerJob) on the same `:active_storage_analysis` queue. 2020-07-13 17:48:09 +02:00			`queue_as :active_storage_analysis`

jobs: ignore deleted file in Virus Scan We have errors in production where the job starts correctly (i.e. the blob exists), but `blob.open` fails with a `ActiveStorage::FileNotFound` error. When checking later in production, the blob has been deleted. This points to the blob (and the file) being deleted during the virus scan job. In that case, ignore the error (rather than retrying the job). 2020-09-03 11:00:59 +02:00			`# If by the time the job runs the blob has been deleted, ignore the error`
jobs: ignore missing blob during virus scan We currently have many failed VirusScannerJob enqueued, because the underlying blob is missing. This PR fixes the issue by discarding the job in those cases (because if the blob is gone, the job is never going to succeed). The implementation is based on a similar issue encoutered by the ActiveStorage::AnalyzeJob. See https://github.com/rails/rails/commit/06f8baf73c677303353c79609838caaeec3ccc9a 2020-07-13 14:31:21 +02:00			`discard_on ActiveRecord::RecordNotFound`
jobs: ignore deleted file in Virus Scan We have errors in production where the job starts correctly (i.e. the blob exists), but `blob.open` fails with a `ActiveStorage::FileNotFound` error. When checking later in production, the blob has been deleted. This points to the blob (and the file) being deleted during the virus scan job. In that case, ignore the error (rather than retrying the job). 2020-09-03 11:00:59 +02:00			`# If the file is deleted during the scan, ignore the error`
			`discard_on ActiveStorage::FileNotFoundError`
jobs: ignore missing blob during virus scan We currently have many failed VirusScannerJob enqueued, because the underlying blob is missing. This PR fixes the issue by discarding the job in those cases (because if the blob is gone, the job is never going to succeed). The implementation is based on a similar issue encoutered by the ActiveStorage::AnalyzeJob. See https://github.com/rails/rails/commit/06f8baf73c677303353c79609838caaeec3ccc9a 2020-07-13 14:31:21 +02:00
jobs: retry on ActiveStorage::IntegrityError during virus scan This is the same setting than what ActiveStorage::AnalyzeJob uses. 2021-03-11 18:36:25 +01:00			`# If for some reason the file appears invalid, retry for a while`
			`retry_on ActiveStorage::IntegrityError, attempts: 10, wait: 5.seconds`

Save virus scan status to blob metadata 2019-05-02 11:37:35 +02:00			`def perform(blob)`
			`metadata = extract_metadata_via_virus_scanner(blob)`
			`blob.update!(metadata: blob.metadata.merge(metadata))`
			`end`

			`def extract_metadata_via_virus_scanner(blob)`
			`ActiveStorage::VirusScanner.new(blob).metadata`
			`end`
			`end`