demarches-normaliennes/spec/models/avis_spec.rb

183 lines
6.4 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
RSpec.describe Avis, type: :model do
let(:claimant) { create(:instructeur) }
describe '#email_to_display' do
let(:invited_email) { 'invited@avis.com' }
2021-02-28 22:20:24 +01:00
let(:expert) { create(:expert) }
let(:procedure) { create(:procedure) }
let(:experts_procedure) { create(:experts_procedure, expert: expert, procedure: procedure) }
subject { avis.email_to_display }
2021-02-28 22:20:24 +01:00
context 'when expert is known' do
let!(:avis) { create(:avis, claimant: claimant, dossier: create(:dossier), experts_procedure: experts_procedure) }
2021-02-28 22:20:24 +01:00
it { is_expected.to eq(avis.expert.email) }
end
end
2017-05-02 13:54:57 +02:00
describe '.by_latest' do
context 'with 3 avis' do
let!(:avis) { create(:avis) }
let!(:avis2) { create(:avis, updated_at: 4.hours.ago) }
let!(:avis3) { create(:avis, updated_at: 3.hours.ago) }
2017-05-02 13:54:57 +02:00
subject { Avis.by_latest }
it { expect(subject).to eq([avis, avis3, avis2]) }
2017-05-02 13:54:57 +02:00
end
end
2021-01-14 20:07:31 +01:00
describe "an avis is linked to an expert_procedure" do
let(:procedure) { create(:procedure) }
let(:expert) { create(:expert) }
let(:experts_procedure) { create(:experts_procedure, procedure: procedure, expert: expert) }
2021-01-14 20:07:31 +01:00
context 'an avis is linked to an experts_procedure' do
let!(:avis) { create(:avis, email: nil, experts_procedure: experts_procedure) }
before do
avis.reload
end
it { expect(avis.valid?).to be_truthy }
2021-01-14 20:07:31 +01:00
it { expect(avis.email).to be_nil }
it { expect(avis.experts_procedure).to eq(experts_procedure) }
end
end
describe "email sanitization" do
2021-02-28 22:20:24 +01:00
let(:expert) { create(:expert) }
let(:procedure) { create(:procedure) }
let!(:experts_procedure) { create(:experts_procedure, expert: expert, procedure: procedure) }
subject { create(:avis, claimant: claimant, email: email, experts_procedure: experts_procedure, dossier: create(:dossier)) }
context "when there is no email" do
let(:email) { nil }
it { expect(subject.email).to be_nil }
end
context "when the email is in lowercase" do
let(:email) { "toto@tps.fr" }
it { expect(subject.email).to eq("toto@tps.fr") }
end
context "when the email is not in lowercase" do
let(:email) { "TOTO@tps.fr" }
it { expect(subject.email).to eq("toto@tps.fr") }
end
2017-10-27 16:27:55 +02:00
context "when the email has some spaces before and after" do
let(:email) { " toto@tps.fr " }
it { expect(subject.email).to eq("toto@tps.fr") }
end
end
2020-07-16 11:14:37 +02:00
describe 'email validation' do
let(:now_invalid_email) { "toto@tps" }
context 'new avis' do
before { allow(StrictEmailValidator).to receive(:eligible_to_new_validation?).and_return(true) }
it { expect(build(:avis, email: now_invalid_email).valid?).to be_falsey }
it { expect(build(:avis, email: nil).valid?).to be_truthy }
end
context 'old avis' do
before { allow(StrictEmailValidator).to receive(:eligible_to_new_validation?).and_return(false) }
it { expect(build(:avis, email: now_invalid_email).valid?).to be_truthy }
it { expect(build(:avis, email: nil).valid?).to be_truthy }
end
end
describe ".revoke_by!" do
let(:claimant) { create(:instructeur) }
2020-07-16 11:14:37 +02:00
context "when no answer" do
let(:avis) { create(:avis, claimant: claimant) }
2020-07-16 11:14:37 +02:00
it "supprime l'avis" do
avis.revoke_by!(claimant)
2020-07-16 11:14:37 +02:00
expect(avis).to be_destroyed
expect(Avis.count).to eq 0
end
end
context "with answer" do
let(:avis) { create(:avis, :with_answer, claimant: claimant) }
2020-07-16 11:14:37 +02:00
it "revoque l'avis" do
avis.revoke_by!(claimant)
2020-07-16 11:14:37 +02:00
expect(avis).not_to be_destroyed
expect(avis).to be_revoked
end
end
context "by an instructeur who can't revoke" do
let(:avis) { create(:avis, :with_answer, claimant: claimant) }
let(:expert) { create(:instructeur) }
it "doesn't revoke avis and returns false" do
result = avis.revoke_by!(expert)
expect(result).to be_falsey
expect(avis).not_to be_destroyed
expect(avis).not_to be_revoked
end
end
end
describe "revokable_by?" do
let(:instructeur) { create(:instructeur) }
let(:instructeurs) { [instructeur] }
let(:procedure) { create(:procedure, :published, instructeurs: instructeurs) }
let(:dossier) { create(:dossier, :en_instruction, procedure: procedure) }
let(:claimant_expert) { create(:instructeur) }
2021-02-28 22:20:24 +01:00
let(:expert) { create(:expert) }
let(:experts_procedure) { create(:experts_procedure, expert: expert, procedure: procedure) }
2021-02-28 22:20:24 +01:00
let(:another_expert) { create(:expert) }
context "when avis claimed by an expert" do
2021-02-28 22:20:24 +01:00
let(:avis) { create(:avis, dossier: dossier, claimant: claimant_expert, experts_procedure: experts_procedure) }
let(:another_avis) { create(:avis, dossier: dossier, claimant: instructeur, experts_procedure: experts_procedure) }
it "is revokable by this expert or any instructeurs of the dossier" do
expect(avis.revokable_by?(claimant_expert)).to be_truthy
expect(avis.revokable_by?(another_expert)).to be_falsy
expect(avis.revokable_by?(instructeur)).to be_truthy
end
end
context "when avis claimed by an instructeur" do
2021-02-28 22:20:24 +01:00
let(:expert) { create(:expert) }
let(:expert_2) { create(:expert) }
let!(:procedure) { create(:procedure, :published, instructeurs: instructeurs) }
let(:experts_procedure) { create(:experts_procedure, expert: expert, procedure: procedure) }
let(:experts_procedure_2) { create(:experts_procedure, expert: expert_2, procedure: procedure) }
2021-02-28 22:20:24 +01:00
let(:avis) { create(:avis, dossier: dossier, claimant: instructeur, experts_procedure: experts_procedure) }
let(:another_avis) { create(:avis, dossier: dossier, claimant: expert, experts_procedure: experts_procedure_2) }
let(:another_instructeur) { create(:instructeur) }
let(:instructeurs) { [instructeur, another_instructeur] }
it "is revokable by any instructeur of the dossier, not by an expert" do
expect(avis.revokable_by?(instructeur)).to be_truthy
expect(avis.revokable_by?(another_expert)).to be_falsy
expect(avis.revokable_by?(another_instructeur)).to be_truthy
end
end
2020-07-16 11:14:37 +02:00
end
describe "question_label cleanup" do
it "nullify empty" do
avis = create(:avis, question_label: " ")
expect(avis.question_label).to be_nil
end
it "strip" do
avis = create(:avis, question_label: "my question ")
expect(avis.question_label).to eq("my question")
end
end
end