fix(filter): in presence of filtering, do not attempt to load all node configurations

I don't know why this was done this way but it's clearly wrong.

Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
This commit is contained in:
Raito Bezarius 2025-01-08 22:35:21 +01:00
parent 78e9f57b10
commit dfe5511ea2

View file

@ -260,8 +260,6 @@ impl Hive {
ssh_config: Option<PathBuf>,
ssh_only: bool,
) -> ColmenaResult<HashMap<NodeName, TargetNode>> {
let mut node_configs = None;
log::info!("Enumerating systems...");
let registry = self.get_registry_config().await?;
@ -279,8 +277,6 @@ impl Hive {
.into_iter()
.collect();
node_configs = Some(all_node_configs);
filtered
} else {
filter.filter_node_names(&all_nodes)?.into_iter().collect()
@ -291,9 +287,7 @@ impl Hive {
let n_selected = selected_nodes.len();
let mut node_configs = if let Some(configs) = node_configs {
configs
} else {
let mut node_configs = {
log::debug!("Retrieving deployment info for selected nodes...");
self.deployment_info_selected(&selected_nodes).await?
};