DGNum/authens
13
0
Fork 0
Code Issues 2 Pull requests Packages Projects Releases 2 Wiki Activity

Handle LOGOUT_URL=None in the logout view

Browse source 
The view used to crash when `LOGOUT_URL` was not set and the user was
connect via CAS.

Cause: we assumed the result of `LogoutView.get_next_page()` to be a
  string and tried to prepend the domain name of the site to it.

Fix: redirect to the CAS' logout view without any `next_page` parameter.
This commit is contained in:
Martin Pépin 2021-10-02 17:02:30 +02:00
parent 47f99f487e
commit acea5a6f4e
No known key found for this signature in database
GPG key ID: E7520278B1774448
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
authens/views.py
View file

@ -145,7 +145,7 @@ class LogoutView(auth_views.LogoutView):
# If the next_url is local (no hostname), make it absolute so that the user
# is correctly redirected from CAS.
if not urlparse(next_page).netloc:
if next_page and not urlparse(next_page).netloc:
request = self.request
next_page = urlunparse(
(request.scheme, request.get_host(), next_page, "", "", "")